Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A separate attempt at the renderers fix, and some related changes (C4-627) #1465

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
27 changes: 22 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,17 @@ deploy2: # spins up waittress to serve the application
pserve development.ini

psql-dev: # starts psql with the url after 'sqlalchemy.url =' in development.ini
@psql `grep 'sqlalchemy[.]url =' development.ini | sed -E 's/^.* = (.*)/\1/'`
@scripts/psql-start dev

kibana-start:
psql-test: # starts psql with a url constructed from data in 'ps aux'.
@scripts/psql-start test

kibana-start: # starts a dev version of kibana (default port)
scripts/kibana-start

kibana-start-test: # starts a test version of kibana (port chosen for active tests)
scripts/kibana-start test

kibana-stop:
scripts/kibana-stop

Expand All @@ -117,19 +123,27 @@ test:
make test-unit
make test-npm

retest:
bin/test -vv --last-failed

test-any:
bin/test -vv --timeout=200


test-npm:
bin/test -vv --timeout=200 -m "working and not manual and not integratedx and not performance and not broken and not sloppy and workbook"

test-unit:
bin/test -vv --timeout=200 -m "working and not manual and not integratedx and not performance and not broken and not sloppy and not workbook"

test-performance:
bin/test -vv --timeout=200 -m "working and not manual and not integratedx and performance and not broken and not sloppy"

test-integrated:
bin/test -vv --timeout=200 -m "working and not manual and (integrated or integratedx) and not performance and not broken and not sloppy"

travis-test: # Actually, we don't normally use this. Instead the GA workflow sets up two parallel tests.
make travis-test-npm
make travis-test-unit
make travis-test-npm

travis-test-npm: # Note this only does the 'not indexing' tests
bin/test -vv --force-flaky --max-runs=3 --timeout=300 -m "working and not manual and not integratedx and not performance and not broken and not sloppy and workbook" --aws-auth --durations=10 --cov src/encoded --es search-fourfront-testing-6-8-kncqa2za2r43563rkcmsvgn2fq.us-east-1.es.amazonaws.com:443
Expand All @@ -154,11 +168,14 @@ info:
$(info - Use 'make configure' to install poetry. You should not have to do this directly.)
$(info - Use 'make deploy1' to spin up postgres/elasticsearch and load inserts.)
$(info - Use 'make deploy2' to spin up the application server.)
$(info - Use 'make kibana-start' to start kibana, and 'make kibana-stop' to stop it.)
$(info - Use 'make kibana-start' to start kibana on the default local ES port, and 'make kibana-stop' to stop it.)
$(info - Use 'make kibana-start-test' to start kibana on the port being used for active testing, and 'make kibana-stop' to stop it.)
$(info - Use 'make kill' to kill postgres and elasticsearch proccesses. Please use with care.)
$(info - Use 'make moto-setup' to install moto, for less flaky tests. Implied by 'make build'.)
$(info - Use 'make npm-setup' to build the front-end. Implied by 'make build'.)
$(info - Use 'make psql-dev' to start psql on data associated with an active 'make deploy1'.)
$(info - Use 'make psql-test' to start psql on data associated with an active test.)
$(info - Use 'make retest' to run failing tests from the previous test run.)
$(info - Use 'make test' to run tests with normal options similar to what we use on GitHub Actions.)
$(info - Use 'make test-any' to run tests without marker constraints (i.e., with no '-m' option).)
$(info - Use 'make update' to update dependencies (and the lock file).)
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tool.poetry]
# Note: Various modules refer to this system as "encoded", not "fourfront".
name = "encoded"
version = "2.6.1"
version = "2.6.2"
description = "4DN-DCIC Fourfront"
authors = ["4DN-DCIC Team <[email protected]>"]
license = "MIT"
Expand Down
2 changes: 2 additions & 0 deletions src/encoded/loadxl.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import webtest

from base64 import b64encode
from dcicutils.misc_utils import ignored
from PIL import Image
from pkg_resources import resource_filename
from pyramid.paster import get_app
Expand Down Expand Up @@ -97,6 +98,7 @@ def load_data_view(context, request):
2) store in form of {'item_type': [items], 'item_type2': [items]}
item_type should be same as insert file names i.e. file_fastq
"""
ignored(context)
# this is a bit wierd but want to reuse load_data functionality so I'm rolling with it
config_uri = request.json.get('config_uri', 'production.ini')
patch_only = request.json.get('patch_only', False)
Expand Down
Loading