Fix mempool.space ios tests #622
Conversation
These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode.
sstone
force-pushed
the
snapshot/fix-mempool-ios-tests
branch
from
cc00511
to
3a3d8de
Compare
|
See https://youtrack.jetbrains.com/issue/KT-38317 for a relevant issue, and the workaround I'm using here. |
|
Wow, the fix is pretty involved. For the CI it's probably fine, but I'm a bit worried about the implication on a normal dev machine, would such global calls not have side effects and break the environment? Let's wait for @robbiehanson's opinion |
It is needed to run mempool.space tests but the fix may breaks things on developer's machine, here it's limited to github CI.
There's another workaround in https://youtrack.jetbrains.com/issue/KT-61470/Kotlin-Native-Keychain-operations-fail-in-iOS-tests-due-to-missing-entitlements but it's even more complex... it also mentions that the underlying issue will be fixed in Kotlin 2.1.0. I agree that this fix may break things on dev machine, so now it will only be used on github's CI, |
So the tests will keep failing on dev machine, that's right? There is no filtering to only run test on CI. I think it's good that way, just making sure. |
Yes they will run and fail on dev machines. |
|
I can confirm that the various MempoolSpace tests fail on my machine (macOS) as expected. But all other tests succeed. And a |
* Fix mempool.space ios tests on github CI These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode. We modified our build and github CI workflow to run tests with `./gradlew -PiosSimulatorMode=standalone` and start the emulator "manually". Builds on dev machine remains the same and mempool.space will still fail on dev machine (unless users set `-PiosSimulatorMode=standalone` ) * Set version to 1.6.2-FEECREDIT-5
* Fix mempool.space ios tests on github CI These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode. We modified our build and github CI workflow to run tests with `./gradlew -PiosSimulatorMode=standalone` and start the emulator "manually". Builds on dev machine remains the same and mempool.space will still fail on dev machine (unless users set `-PiosSimulatorMode=standalone` ) * Set version to 1.6.2-FEECREDIT-5
* Fix mempool.space ios tests on github CI These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode. We modified our build and github CI workflow to run tests with `./gradlew -PiosSimulatorMode=standalone` and start the emulator "manually". Builds on dev machine remains the same and mempool.space will still fail on dev machine (unless users set `-PiosSimulatorMode=standalone` ) * Set version to 1.6.2-FEECREDIT-5
* Fix mempool.space ios tests on github CI These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode. We modified our build and github CI workflow to run tests with `./gradlew -PiosSimulatorMode=standalone` and start the emulator "manually". Builds on dev machine remains the same and mempool.space will still fail on dev machine (unless users set `-PiosSimulatorMode=standalone` ) * Set version to 1.6.2-FEECREDIT-5
* Fix mempool.space ios tests on github CI These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode. We modified our build and github CI workflow to run tests with `./gradlew -PiosSimulatorMode=standalone` and start the emulator "manually". Builds on dev machine remains the same and mempool.space will still fail on dev machine (unless users set `-PiosSimulatorMode=standalone` ) * Set version to 1.6.2-FEECREDIT-5
* Fix mempool.space ios tests on github CI These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode. We modified our build and github CI workflow to run tests with `./gradlew -PiosSimulatorMode=standalone` and start the emulator "manually". Builds on dev machine remains the same and mempool.space will still fail on dev machine (unless users set `-PiosSimulatorMode=standalone` )
These tests include https calls which won't work if the ios simulator is started in standalone mode, which is the default mode.