Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the PreviewSurface Nodegraph #2084

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

klucknav
Copy link
Contributor

@klucknav klucknav commented Oct 24, 2024

This PR updates the PreviewSurface Nodegraph to address the opacity issue in cutout mode described in gitIssue #2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.6 spec which states that fully transparent materials do not have a lighting response. Since the preview surface glass example was fully transparent, it is also updated to have a very slight opacity value.

klucknav and others added 10 commits October 21, 2024 15:18
…oundation#2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.5 which removes specular highlights for fully transparent materials.
A recent change updated the nodegraph to reflect the updated PreviewSurface v2.5, which removes specular highlights for fully transparent materials. This change makes it such that opacity = 0 is treated the same regardless of if we use the transmissionOpacity or transmissionRefraction options, or if the material is in cutout or transparency mode.
This change maintains the current behavior when using 'transmissiveRefraction' method, while also keeping the opacity = 0 behavior consistent between the `transmissiveOpacity` and `transmissiveRefraction` methods.
@klucknav klucknav changed the title Additional changes to the PreviewSurface Nodegraph Updates to the PreviewSurface Nodegraph Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants