Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the PreviewSurface Nodegraph #2084

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Updates to the PreviewSurface Nodegraph #2084

wants to merge 11 commits into from
+15 −3

Commits on Oct 21, 2024

  1. This PR fixes the cutout issue described in gitIssue AcademySoftwareF… 

    …oundation#2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.5 which removes specular highlights for fully transparent materials.
    @klucknav
    klucknav committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a6b1bac View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Additional changes to the PreviewSurface Nodegraph 

    A recent change updated the nodegraph to reflect the updated PreviewSurface v2.5, which removes specular highlights for fully transparent materials. This change makes it such that opacity = 0 is treated the same regardless of if we use the transmissionOpacity or transmissionRefraction options, or if the material is in cutout or transparency mode.
    @klucknav
    klucknav committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ed3ad99 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Update to the Preview Surface Glass example to have a slight opacity.

    @klucknav
    klucknav committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    198bb74 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into klucknav-updatePreviewSurfaceGraph

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c814530 View commit details
    Browse the repository at this point in the history

  3. Update type from integer to float 

    Signed-off-by: Jonathan Stone <[email protected]>
    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    fdde173 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into klucknav-updatePreviewSurfaceGraph

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ad8c52c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Additional nodegraph updates 

    This change maintains the current behavior when using 'transmissiveRefraction' method, while also keeping the opacity = 0 behavior consistent between the `transmissiveOpacity` and `transmissiveRefraction` methods.
    @klucknav
    klucknav committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    baa8861 View commit details
    Browse the repository at this point in the history

  2. Re order node inputs

    @klucknav
    klucknav committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    501d52a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge branch 'main' into klucknav-updatePreviewSurfaceGraph

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    65e8320 View commit details
    Browse the repository at this point in the history

  2. Incorporate the fix for the cutout issue described in gitIssue Academ… 

    …ySoftwareFoundation#2044.
    @klucknav
    klucknav committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2637cb2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into klucknav-updatePreviewSurfaceGraph

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    16b7878 View commit details
    Browse the repository at this point in the history