-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to the PreviewSurface Nodegraph #2084
Open
klucknav
wants to merge
11
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
klucknav:klucknav-updatePreviewSurfaceGraph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updates to the PreviewSurface Nodegraph #2084
klucknav
wants to merge
11
commits into
AcademySoftwareFoundation:main
from
klucknav:klucknav-updatePreviewSurfaceGraph
+15
−3
Commits on Oct 21, 2024
-
This PR fixes the cutout issue described in gitIssue AcademySoftwareF…
…oundation#2044. It also updates the nodegraph to reflect the recently updated PreviewSurface v2.5 which removes specular highlights for fully transparent materials.
Configuration menu - View commit details
-
Copy full SHA for a6b1bac - Browse repository at this point
Copy the full SHA a6b1bacView commit details
Commits on Oct 23, 2024
-
Additional changes to the PreviewSurface Nodegraph
A recent change updated the nodegraph to reflect the updated PreviewSurface v2.5, which removes specular highlights for fully transparent materials. This change makes it such that opacity = 0 is treated the same regardless of if we use the transmissionOpacity or transmissionRefraction options, or if the material is in cutout or transparency mode.
Configuration menu - View commit details
-
Copy full SHA for ed3ad99 - Browse repository at this point
Copy the full SHA ed3ad99View commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 198bb74 - Browse repository at this point
Copy the full SHA 198bb74View commit details -
Configuration menu - View commit details
-
Copy full SHA for c814530 - Browse repository at this point
Copy the full SHA c814530View commit details -
Update type from integer to float
Signed-off-by: Jonathan Stone <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fdde173 - Browse repository at this point
Copy the full SHA fdde173View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad8c52c - Browse repository at this point
Copy the full SHA ad8c52cView commit details
Commits on Oct 25, 2024
-
This change maintains the current behavior when using 'transmissiveRefraction' method, while also keeping the opacity = 0 behavior consistent between the `transmissiveOpacity` and `transmissiveRefraction` methods.
Configuration menu - View commit details
-
Copy full SHA for baa8861 - Browse repository at this point
Copy the full SHA baa8861View commit details -
Configuration menu - View commit details
-
Copy full SHA for 501d52a - Browse repository at this point
Copy the full SHA 501d52aView commit details
Commits on Oct 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65e8320 - Browse repository at this point
Copy the full SHA 65e8320View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2637cb2 - Browse repository at this point
Copy the full SHA 2637cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16b7878 - Browse repository at this point
Copy the full SHA 16b7878View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.