Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image overhaul (WIP) #236

Draft
wants to merge 3 commits into
base: dev_1.2
Choose a base branch
from

Conversation

portsmouth
Copy link
Contributor

Updating images to use the new shaderball, and adding some new images.

Also indenting the anisotropy diagram to make it less distracting.

image

@portsmouth portsmouth marked this pull request as draft September 3, 2024 16:10
@portsmouth portsmouth changed the title Image overhaul Image overhaul (WIP) Sep 3, 2024
@@ -1000,6 +1004,11 @@

The base albedo $E_b$ which appears in equation [general_darkening_formula] represents the normal-incidence albedo of the entire base beneath the coat. This albedo can be approximated as the normal-incidence albedos of the individual slabs of the base, blended according to their mix weights.

![](images/coat_darkening_0.0.png width=99%) ![](images/coat_darkening_0.5.png width=99%) ![](images/coat_darkening_1.png width=99%)
<div class="shifted-caption">
![Figure [fuzz]: A checkerboard **`coat_weight`**, varying the **`coat_darkening`** over 0, 0.5, 1 (default).](dummy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this particular illustration difficult to understand. The wood looks glossy everywhere, which I interpret as coated everywhere. If the intent is to show a checker of coated vs non coated parts, I'd suggest using a rough base layer.

@portsmouth portsmouth changed the base branch from main to dev_1.2 October 1, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants