Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests if not enough balance #378

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Oct 11, 2024

The PR:

  • Verifies user1 and bidder balance before executing all tests. This is done to exit early in case the balances are not enough to carry out test operations. Previously, we had executed a major section of tests before realizing that we didn't possess enough balance to create a vault or make a bid.
  • Removes an A3P test for creating a vault which is no longer required. Previously, this test case was added to ensure gov1 has enough IST to make bids. But this is no longer required because gov1 already have enough balance to carry out bidding stuff.
  • Adding logs wherever we execute commands with agops and agd.

@rabi-siddique rabi-siddique changed the base branch from main to rs-decimal-places-verification October 11, 2024 06:12
Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying agoric-dapp-inter-emerynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: e2ed085
Status: ✅  Deploy successful!
Preview URL: https://501c2faa.agoric-dapp-inter-emerynet.pages.dev
Branch Preview URL: https://rs-skip-tests-if-not-enough.agoric-dapp-inter-emerynet.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying dapp-inter-test with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76a4deb
Status:⚡️  Build in progress...

View logs

@rabi-siddique rabi-siddique added the liquidation-testing Trigger E2E tests for Liquidation label Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Network:
Commit: 401b002
Ref: refs/heads/main
IPFS v1 hash: bafybeifw2fsj7v6jhbyfhb5cubt3d6md6vb6z6vwhh4mkkzgqet42eexle
CF - DWeb - 4EVERLAND

@rabi-siddique rabi-siddique added the liquidation-reconstitution-testing Trigger E2E tests for Liquidation-Reconstitution label Oct 11, 2024
Base automatically changed from rs-decimal-places-verification to main October 11, 2024 07:07
@rabi-siddique rabi-siddique force-pushed the rs-skip-tests-if-not-enough-balance branch 2 times, most recently from 1e378e8 to e2ed085 Compare October 11, 2024 09:33
@rabi-siddique rabi-siddique marked this pull request as ready for review October 11, 2024 10:10
@rabi-siddique rabi-siddique force-pushed the rs-skip-tests-if-not-enough-balance branch from e2ed085 to 76a4deb Compare October 11, 2024 10:44
@rabi-siddique rabi-siddique merged commit 401b002 into main Oct 11, 2024
4 of 6 checks passed
@rabi-siddique rabi-siddique deleted the rs-skip-tests-if-not-enough-balance branch October 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
liquidation-reconstitution-testing Trigger E2E tests for Liquidation-Reconstitution liquidation-testing Trigger E2E tests for Liquidation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants