-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in sORF prediction to peptigate using plmutils #22
Conversation
Just to close the loop on this, we chatted offline and agreed to include the model files in the repo, as this is the simplest solution, it allows the dry-run action to pass, and the model files are not currently large or numerous enough to justify storing them elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few nits but nothing major. And it's totally fine by me to punt on my documentation-related comments to a future documentation PR.
Merging now! there should be an additional chance for review/changes in a docs PR. |
PR checklist
Fixes #123, Resolves #456
).conda
environments.PR Description
This PR adds in sORF peptide prediction based on plmutils. A lot of the code I had in place for sORF prediction was changed or deleted now that we aren't using RNAsamba. I didn't have to add any new environments, as everything was already present from the curation/model snakefile and the existing workflow.
I decided to add the plmutils model as a config path. @keithchev, I would appreciate input as to the best way to provide the models, info for the two files is below:
I think I'd like to provide them in the repo (then the snakemake dry run in the github actions will also pass...), but I can switch things up to make them downloadable instead, or to provide them as a tar file and decompress them in the workflow. I didn't want to add them yet so as not to make the github history huge if we go the route of not putting them in the repo.
Documentation PR coming soon!
Testing
I confirmed that the new code runs on the test data set and outputs desired results.