Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update three dots icon size #806

Merged
merged 7 commits into from
Nov 11, 2024
Merged

refactor: update three dots icon size #806

merged 7 commits into from
Nov 11, 2024

Conversation

patricio0312rev
Copy link
Contributor

@patricio0312rev patricio0312rev commented Nov 11, 2024 •
edited
Loading

[wallet details] 3 dot menu icon size

Summary

  • The 3 dots icon size has been updated for the wallet header. The icon has also been updated and now has the dots filled.
  • Other implementations for the icon have also been updated in:
    • Custom peer cards (in settings)
    • Custon network icons (in settings)
    • Skeleton loaders (for the wallet header and profile cards)
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 11, 2024 8:38am

@patricio0312rev patricio0312rev added this to the 1.18.0 milestone Nov 11, 2024
@ItsANameToo ItsANameToo merged commit 0b05311 into develop Nov 11, 2024
20 checks passed
@ItsANameToo ItsANameToo deleted the refactor/three-dots-menu-icon-size branch November 11, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@patricio0312rev @ItsANameToo @samharperpittam