Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update three dots icon size #806

Merged
merged 7 commits into from
Nov 11, 2024
Merged

refactor: update three dots icon size #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6935894
refactor: update three dots icon size
patricio0312rev Nov 11, 2024
d538691
style: resolve style guide violations
patricio0312rev Nov 11, 2024
9ff52a8
chore: update snapshots
patricio0312rev Nov 11, 2024
3f506c8
Merge branch 'refactor/three-dots-menu-icon-size' of https://github.c…
patricio0312rev Nov 11, 2024
f474496
chore: update snapshots
patricio0312rev Nov 11, 2024
069082e
chore: update snapshots
patricio0312rev Nov 11, 2024
950054d
wip
ItsANameToo Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/components/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const Card = ({ variant, children, addonIcons, actions, onClick, onSelect
<Icon
name="EllipsisVertical"
className="cursor-pointer p-1 text-theme-primary-300 transition-colors duration-200 hover:text-theme-primary-400 dark:text-theme-secondary-600 dark:hover:text-theme-secondary-200"
size="lg"
size="md"
/>
</div>
}
Expand Down
6 changes: 3 additions & 3 deletions src/app/components/Card/__snapshots__/Card.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ exports[`Card > should render with custom options 1`] = `
class="flex w-4 justify-center overflow-hidden"
>
<div
class="cursor-pointer p-1 text-theme-primary-300 transition-colors duration-200 hover:text-theme-primary-400 dark:text-theme-secondary-600 dark:hover:text-theme-secondary-200 css-1i4b0eq"
height="20"
width="20"
class="cursor-pointer p-1 text-theme-primary-300 transition-colors duration-200 hover:text-theme-primary-400 dark:text-theme-secondary-600 dark:hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
<svg
id="ellipsis-vertical"
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/PageSkeleton/__snapshots__/PageSkeleton.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ exports[`PageSkeleton > should render without profile 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -525,7 +525,7 @@ exports[`PageSkeleton > should render without profile 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down
4 changes: 2 additions & 2 deletions src/app/components/WalletListItem/WalletListItemSkeleton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export const WalletListItemSkeleton: React.VFC = () => {
variant="transparent"
size="icon"
disabled={true}
className="-mr-1.5 text-theme-primary-300 hover:text-theme-primary-600"
className="text-theme-gray-700 -mr-1.5 hover:bg-theme-primary-200 hover:text-theme-primary-700 dark:hover:bg-theme-secondary-800 dark:hover:text-white"
>
<Icon name="EllipsisVertical" size="lg" />
<Icon name="EllipsisVertical" size="md" />
</Button>
</div>
</TableCell>
Expand Down
16 changes: 8 additions & 8 deletions src/app/components/WalletListItem/__snapshots__/WalletListItemSkeleton.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,17 @@ exports[`WalletListItemSkeleton > should render wallet list skeleton when isComp
data-testid="WalletHeader__more-button"
>
<button
class="p-3 relative items-center inline-flex justify-center font-semibold leading-tight text-center transition-colors-shadow duration-100 ease-linear outline-none rounded focus:outline-none focus:ring-2 focus:ring-theme-primary-400 disabled:cursor-not-allowed disabled:text-theme-secondary-400 dark:disabled:text-theme-secondary-700 -mr-1.5 text-theme-primary-300 hover:text-theme-primary-600"
class="p-3 relative items-center inline-flex justify-center font-semibold leading-tight text-center transition-colors-shadow duration-100 ease-linear outline-none rounded focus:outline-none focus:ring-2 focus:ring-theme-primary-400 disabled:cursor-not-allowed disabled:text-theme-secondary-400 dark:disabled:text-theme-secondary-700 text-theme-gray-700 -mr-1.5 hover:bg-theme-primary-200 hover:text-theme-primary-700 dark:hover:bg-theme-secondary-800 dark:hover:text-white"
disabled=""
type="button"
>
<div
class="flex items-center space-x-2"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
id="ellipsis-vertical"
Expand Down Expand Up @@ -342,17 +342,17 @@ exports[`WalletListItemSkeleton > should render wallet list skeleton when isComp
data-testid="WalletHeader__more-button"
>
<button
class="p-3 relative items-center inline-flex justify-center font-semibold leading-tight text-center transition-colors-shadow duration-100 ease-linear outline-none rounded focus:outline-none focus:ring-2 focus:ring-theme-primary-400 disabled:cursor-not-allowed disabled:text-theme-secondary-400 dark:disabled:text-theme-secondary-700 -mr-1.5 text-theme-primary-300 hover:text-theme-primary-600"
class="p-3 relative items-center inline-flex justify-center font-semibold leading-tight text-center transition-colors-shadow duration-100 ease-linear outline-none rounded focus:outline-none focus:ring-2 focus:ring-theme-primary-400 disabled:cursor-not-allowed disabled:text-theme-secondary-400 dark:disabled:text-theme-secondary-700 text-theme-gray-700 -mr-1.5 hover:bg-theme-primary-200 hover:text-theme-primary-700 dark:hover:bg-theme-secondary-800 dark:hover:text-white"
disabled=""
type="button"
>
<div
class="flex items-center space-x-2"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
id="ellipsis-vertical"
Expand Down
2 changes: 1 addition & 1 deletion src/domains/contact/components/ContactListMobile/ContactListItemMobile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const ContactListItemMobile: React.VFC<Properties> = ({
<Dropdown
toggleContent={
<button type="button" className="flex text-theme-secondary-700">
<Icon name="EllipsisVerticalFilled" size="lg" />
<Icon name="EllipsisVerticalFilled" size="md" />
</button>
}
options={options}
Expand Down
12 changes: 6 additions & 6 deletions ...ns/contact/components/ContactListMobile/__snapshots__/ContactListItemMobile.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ exports[`ContactListItemMobile > should render 1`] = `
type="button"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
fill="none"
Expand Down Expand Up @@ -144,9 +144,9 @@ exports[`ContactListItemMobile > should render addresses 1`] = `
type="button"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
fill="none"
Expand Down
6 changes: 3 additions & 3 deletions ...omains/contact/components/ContactListMobile/__snapshots__/ContactListMobile.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ exports[`ContactListMobile > should render 1`] = `
type="button"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
fill="none"
Expand Down
12 changes: 6 additions & 6 deletions src/domains/contact/pages/Contacts/__snapshots__/Contacts.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2298,9 +2298,9 @@ exports[`Contacts > should render responsive with contacts 1`] = `
type="button"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
fill="none"
Expand Down Expand Up @@ -2404,9 +2404,9 @@ exports[`Contacts > should render responsive with contacts 1`] = `
type="button"
>
<div
class="css-1i4b0eq"
height="20"
width="20"
class="css-v0ob3f"
height="16"
width="16"
>
<svg
fill="none"
Expand Down
2 changes: 1 addition & 1 deletion src/domains/profile/components/ProfileRow/ProfileRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const ProfileRowSkeleton = () => (
<div className="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800" />
<Icon
name="EllipsisVerticalFilled"
className="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800"
className="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200"
size="md"
/>
</div>
Expand Down
24 changes: 12 additions & 12 deletions src/domains/profile/components/ProfileRow/__snapshots__/ProfileRow.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`ProfileSliderSkeleton > should render 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -55,7 +55,7 @@ exports[`ProfileSliderSkeleton > should render 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -96,7 +96,7 @@ exports[`ProfileSliderSkeleton > should render 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -137,7 +137,7 @@ exports[`ProfileSliderSkeleton > should render 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -178,7 +178,7 @@ exports[`ProfileSliderSkeleton > should render 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -230,7 +230,7 @@ exports[`ProfileSliderSkeleton > should render with dots 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -271,7 +271,7 @@ exports[`ProfileSliderSkeleton > should render with dots 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -312,7 +312,7 @@ exports[`ProfileSliderSkeleton > should render with dots 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -353,7 +353,7 @@ exports[`ProfileSliderSkeleton > should render with dots 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -394,7 +394,7 @@ exports[`ProfileSliderSkeleton > should render with dots 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -474,7 +474,7 @@ exports[`ProfileSliderSkeleton > should render with length 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down Expand Up @@ -515,7 +515,7 @@ exports[`ProfileSliderSkeleton > should render with length 1`] = `
class="h-10 w-10 bg-theme-secondary-100 dark:bg-theme-secondary-800"
/>
<div
class="mr-1.5 pr-1.5 text-theme-secondary-200 dark:text-theme-secondary-800 css-v0ob3f"
class="mr-1.5 pr-1.5 text-theme-secondary-700 transition-colors duration-200 group-hover:text-theme-navy-700 dark:text-theme-secondary-600 dark:group-hover:text-theme-secondary-200 css-v0ob3f"
height="16"
width="16"
>
Expand Down
2 changes: 1 addition & 1 deletion src/domains/setting/pages/Networks/blocks/CustomNetworksList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const CustomNetworksListNetwork: React.VFC<{
<Icon
name="EllipsisVertical"
className="cursor-pointer p-1 text-theme-primary-300 transition-colors duration-200 hover:text-theme-primary-400 dark:text-theme-secondary-600 dark:hover:text-theme-secondary-200"
size="lg"
size="md"
/>
</div>
}
Expand Down
Loading
Loading