Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature_copter extra channels mapping #1139

Conversation

svefro
Copy link
Contributor

@svefro svefro commented Jun 11, 2014

This adds parameters to copter for channels 5,6,7,8

The Parameter names are discussable.
Let me know and i'll change them.

Also there is a warning for changing RCMAP_THROTTLE since this can cause problems with internal PPM Encoder on APM

This resolves:
#1096
#1103
#685
Heli have CH_ROTORSPEED instead of CH_AUX2

@haygood
Copy link

haygood commented Jun 11, 2014

That should get the job done. Thanks!



#if FRAME_CONFIG == HELI_FRAME
// @Param: CH_ROTORSPEED
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heli "If" is not tested

@tridge
Copy link
Contributor

tridge commented Jun 17, 2014

I've pushed the RCMAP_THROTTLE warning change, thanks
For the rest, I think it would be good for the flightmode channel option to be named to match APM:Plane, which is FLTMODE_CH. That will allow existing GCS code to pick up the change automatically. Then perhaps follow the XXX_CH convention for the others?

@svefro
Copy link
Contributor Author

svefro commented Jun 17, 2014

It is done :)

Is it ok to save the ROTORSPEED_CH param to aux2_ch?

CH_FLIGHTMODE renamed to FLTMODE_CH
Tested in SITL with copter but HELI is untested
ROTORSPEED_CH saves to AUX2_CH
@haygood
Copy link

haygood commented Jul 8, 2014

Obviously, I hardly understand this process, but I'm wondering if anything else needs to be done for this to get done.

@svefro
Copy link
Contributor Author

svefro commented Jul 10, 2014

Yes could someone have a look at merging this. i have made the changes to the parameter names.
Let me know if there is anything more.

@svefro
Copy link
Contributor Author

svefro commented Jul 29, 2014

Could you take a look at this Randy? i see that there is some merge conflicts now. do you want me to resolve them and make a new pull request or will you resolve them?

@haygood
Copy link

haygood commented Sep 1, 2014

I'm still looking forward to this feature being added. It would really expand the usefulness of our Y6.

@haygood
Copy link

haygood commented Sep 18, 2014

Bump for good 'ole #1139, the feature I am personally most anticipating.

Testing, Testing, ... is this thing on?

@svefro
Copy link
Contributor Author

svefro commented Sep 18, 2014

I'm happy to resolve the merge conflicts as long as this feature is accepted. i have this feature on my DIY Quad (Cant use it with my frsky otherwise)

@svefro
Copy link
Contributor Author

svefro commented Sep 22, 2014

I have added a new resolved Pullrequest based on master today 22/9
#1406

@squilter
Copy link
Member

squilter commented Nov 1, 2014

@svefro was this PR replaced by #1406 (ie can this one be closed?)

@tridge tridge added the Copter label Aug 23, 2015
@R-Lefebvre
Copy link
Contributor

I think this should be closed. It's old, and has been replaced by another PR also.

@R-Lefebvre
Copy link
Contributor

Closing this, as it is very old, and will be done in a different way in InputManager

@R-Lefebvre R-Lefebvre closed this Dec 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants