-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature_copter extra channels mapping #1139
Feature_copter extra channels mapping #1139
Conversation
Warning user that changing RCMAP_Throttle could be dangerous
That should get the job done. Thanks! |
|
||
|
||
#if FRAME_CONFIG == HELI_FRAME | ||
// @Param: CH_ROTORSPEED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heli "If" is not tested
I've pushed the RCMAP_THROTTLE warning change, thanks |
It is done :) Is it ok to save the ROTORSPEED_CH param to aux2_ch? |
CH_FLIGHTMODE renamed to FLTMODE_CH Tested in SITL with copter but HELI is untested ROTORSPEED_CH saves to AUX2_CH
Obviously, I hardly understand this process, but I'm wondering if anything else needs to be done for this to get done. |
Yes could someone have a look at merging this. i have made the changes to the parameter names. |
Could you take a look at this Randy? i see that there is some merge conflicts now. do you want me to resolve them and make a new pull request or will you resolve them? |
I'm still looking forward to this feature being added. It would really expand the usefulness of our Y6. |
Bump for good 'ole #1139, the feature I am personally most anticipating. Testing, Testing, ... is this thing on? |
I'm happy to resolve the merge conflicts as long as this feature is accepted. i have this feature on my DIY Quad (Cant use it with my frsky otherwise) |
I have added a new resolved Pullrequest based on master today 22/9 |
I think this should be closed. It's old, and has been replaced by another PR also. |
Closing this, as it is very old, and will be done in a different way in InputManager |
This adds parameters to copter for channels 5,6,7,8
The Parameter names are discussable.
Let me know and i'll change them.
Also there is a warning for changing RCMAP_THROTTLE since this can cause problems with internal PPM Encoder on APM
This resolves:
#1096
#1103
#685
Heli have CH_ROTORSPEED instead of CH_AUX2