-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mount RC failsafe handling #16251
Conversation
e58b784
to
35272ea
Compare
Maybe |
35272ea
to
574590d
Compare
want me to SITL and bench test this? and close mine? |
574590d
to
6e6e426
Compare
Yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
It would be cool to write a small test for this too
On Fri, 8 Jan 2021, Pierre Kancir wrote:
looks like we can merge the two cases
Read a little harder. They *look* very similar :-)
|
On Fri, 8 Jan 2021, Pierre Kancir wrote:
looks like is miss some indent here
Yeah, I retained the original indent for no particularly good reason.
|
6e6e426
to
72008dc
Compare
One word : dyslexia ;-S |
baefd71
to
7b36460
Compare
I tried the pure-virtual thing. It didn't work out. Too much stuff to be reverted when we move the failsafe handling up. |
@peterbarker having a problem running SITL on this...if I use master/realfight griffin to get the mount, setting SIM_RC_FAIL puts it into failsafe...if I load this, it just disconnects RC from the controller box...maybe its a flightaxis thing...but cant test in STIL as is |
btw, noticed that if I use RC mavproxy command it overrides the flight axis control box for that channel until I set RC X 0....probably should document...I assume it also does this in pure Mavproxy if joystick module is used? |
aaadb49
to
891428b
Compare
891428b
to
95821e0
Compare
e22c7ac
to
ac87907
Compare
03340d8
to
9b9decb
Compare
Closes #24093 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me although I wonder if we really need the extra parameter. I would have though just an MNTx_OPTION bit to move to Neutral on RC failsafe would have been enough.
9b9decb
to
2929dcd
Compare
We decided to use an option bit instead of adding the extra parameter, thanks! |
122225e
to
46281af
Compare
|
… it elsewhere this gives all backends the neutral-on-RC-failsafe behaviour
46281af
to
814f1c6
Compare
@Hwurzburg