Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mount RC failsafe handling #16251

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

peterbarker
Copy link
Contributor

@peterbarker
Copy link
Contributor Author

Maybe s/in_rc_failsafe/in_failsafe/

@Hwurzburg
Copy link
Collaborator

want me to SITL and bench test this? and close mine?

@peterbarker
Copy link
Contributor Author

want me to SITL and bench test this? and close mine?

Yes please!

Copy link
Contributor

@khancyr khancyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
It would be cool to write a small test for this too

@peterbarker
Copy link
Contributor Author

peterbarker commented Jan 8, 2021 via email

@peterbarker
Copy link
Contributor Author

peterbarker commented Jan 8, 2021 via email

@khancyr
Copy link
Contributor

khancyr commented Jan 8, 2021

One word : dyslexia ;-S

libraries/RC_Channel/RC_Channel.h Outdated Show resolved Hide resolved
@peterbarker peterbarker force-pushed the pr/in-rc-failsafe branch 2 times, most recently from baefd71 to 7b36460 Compare January 12, 2021 06:46
@peterbarker
Copy link
Contributor Author

I tried the pure-virtual thing. It didn't work out. Too much stuff to be reverted when we move the failsafe handling up.

@Hwurzburg
Copy link
Collaborator

@peterbarker having a problem running SITL on this...if I use master/realfight griffin to get the mount, setting SIM_RC_FAIL puts it into failsafe...if I load this, it just disconnects RC from the controller box...maybe its a flightaxis thing...but cant test in STIL as is

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Jan 12, 2021

btw, noticed that if I use RC mavproxy command it overrides the flight axis control box for that channel until I set RC X 0....probably should document...I assume it also does this in pure Mavproxy if joystick module is used?

@peterbarker
Copy link
Contributor Author

Closes #24093

@peterbarker peterbarker marked this pull request as ready for review May 7, 2024 07:46
@peterbarker peterbarker changed the title Add RC in_rc_failsafe method Add Mount RC failsafe handling May 7, 2024
Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me although I wonder if we really need the extra parameter. I would have though just an MNTx_OPTION bit to move to Neutral on RC failsafe would have been enough.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label May 7, 2024
@tridge tridge removed the DevCallEU label May 8, 2024
@rmackay9
Copy link
Contributor

rmackay9 commented May 8, 2024

We decided to use an option bit instead of adding the extra parameter, thanks!

@peterbarker peterbarker force-pushed the pr/in-rc-failsafe branch 4 times, most recently from 122225e to 46281af Compare November 9, 2024 04:20
@peterbarker
Copy link
Contributor Author

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
CubeRedPrimary                      0      *           -256    -256              -256   -256   -256
Durandal                            *      *           -304    -304              -312   -304   -312
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           -216    -216              -216   -216   -216
MatekF405                           *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      *
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      *
skyviper-journey                                       -112                                    
skyviper-v2450                                         *                                       

libraries/AP_Mount/AP_Mount_Backend.cpp Show resolved Hide resolved
@peterbarker peterbarker merged commit dcc04d6 into ArduPilot:master Nov 12, 2024
99 checks passed
@peterbarker peterbarker deleted the pr/in-rc-failsafe branch November 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants