Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: autotest: add HEXA X configuration #26125

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tatsuy
Copy link
Contributor

@tatsuy tatsuy commented Feb 2, 2024

This PR introduces the following changes:

1. Fixing the ability to correctly set FRAME_TYPE to 1 when specifying --frame=X.
2. Adding support for the --frame=hexax option.

I tested these frame types in SITL

sim_vehicle.py -v ArduCopter -f X -w
sim_vehicle.py -v ArduCopter -f hexax -w

@peterbarker
Copy link
Contributor

Looks like tridge got in ahead of you with the copter-x fix.

Your hexa-x changes look like they might stil be applicable - did you want to pursue those?

@tatsuy tatsuy changed the title Tools: autotest: fix QUAD X and add HEXA X configuration in vehicleinfo Tools: autotest: add HEXA X configuration Apr 11, 2024
@tatsuy
Copy link
Contributor Author

tatsuy commented Apr 11, 2024

@peterbarker Thanks for the feedback.
I checked #26246, and updated the code to remove overlapping modifications.

I tested hexax in SITL, and confirmed no oscillation.

@tatsuy tatsuy force-pushed the pr-frame-type-x branch 2 times, most recently from b64e59c to d0bd78b Compare April 15, 2024 23:09
@peterbarker peterbarker merged commit 3b51278 into ArduPilot:master Apr 17, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants