DroneCAN: fixed handling of bad multi-frame pkts and check array bounds #26186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-canard-decode-fixes
branch
from
3f1484f
to
682ebb8
Compare
tridge
force-pushed
the
pr-canard-decode-fixes
branch
from
ced5524
to
54aeccf
Compare
bugobliterator
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by a watchdog from corrupt DroneCAN packets where the initial frames for a multi-frame packet were sent more than once. It exposed a vulnerability in our DroneCAN packet decoder.
Note that the nature of the bug meant that the 16 bit CRC did not protect us against bad packets
This includes the following two PRs: