Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: fix shebangs - /bin/bash -> /usr/bin/env bash #26196

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

sorki
Copy link
Contributor

@sorki sorki commented Feb 12, 2024

Most scripts/tools use non-portable /bin/bash, switch to environment agnostic /usr/bin/env bash.

Most scripts/tools use non-portable `/bin/bash`, switch
to environment agnostic `/usr/bin/env bash`.
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right.

Was it causing an issue?

Marked for DevCall to see what people think of treewide: as a concept...

@sorki
Copy link
Contributor Author

sorki commented Feb 12, 2024

On NixOS there's no /bin/bash 😄 There's only /bin/sh and /usr/bin/env (only two binaries in these directories).

This allows using scripts and building everything on NixOS - If there's interest I can publish a follow-up PRs with Nix files that allow quickly setting up a development shell or performing a full build without having to fiddle with dependencies.

@peterbarker peterbarker merged commit 04b4667 into ArduPilot:master Feb 13, 2024
99 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants