Move PositionControl logging (PSCN, PSCE, PSCD) into AC_AttitudeControl library #26351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/move-poscontrol-logging
branch
from
304f862
to
acfa299
Compare
rmackay9
reviewed
Feb 29, 2024
| { | ||
| const struct log_PSCx pkt{ | ||
| LOG_PACKET_HEADER_INIT(id), | ||
| time_us : AP_HAL::micros64(), |
There was a problem hiding this comment.
nitpick: small whitespace issue but preexisting it seems..
rmackay9
approved these changes
Feb 29, 2024
peterbarker
force-pushed
the
pr/move-poscontrol-logging
branch
from
acfa299
to
5e75961
Compare
peterbarker
force-pushed
the
pr/move-poscontrol-logging
branch
from
5e75961
to
2950ff6
Compare
Build errors fixed. |
lthall
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves these closer to where they are used, less scattered across the codebase. We've done the same for a lot of libraries (e.g. the EKFs) and it has worked well.