Handle esc extended status #27004
Closed
Handle esc extended status #27004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loki077 i'm happy for it to be logged in DroneCAN for now. We may move it if we get other protocols that can carry this information |
loki077
force-pushed
the
handle_esc_extended_status
branch
from
fa7d1d3
to
c97d31d
Compare
|
Already being implemented by #27248 so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to allow logging of ESC extended status.
It is still not a finished changes and an rushed push will update the PR tomorrow.
Mainly I need an opinion on if the ESC extended packets need to be logged in DroneCAN or AP_ESC_Telem. Also, if this is needed to pushed on Mavlink? I don't have a requirement for it.