MOUNT: Add a mount2 retract #27352
Merged
MOUNT: Add a mount2 retract #27352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khancyr
approved these changes
Jun 21, 2024
|
Hi @muramura, We discussed at this week's EU dev call and to save flash could you please add a new method called, "do_aux_function_retract_mount()" that takes a "ch_flag" and a "uint8_t instance" which is set to 0 or 1 depending upon whether we're handling RETRACT_MOUNT1 or RETRACT_MOUNT2? then use this new method to handle both of the RETRACT_MOUNT1/2 events. |
|
@rmackay9 san. I understand. I have made the changes. |
muramura
force-pushed
the
AP_Add_a_MOUNT2_retract
branch
from
175f5a7
to
9c0487c
Compare
rmackay9
approved these changes
Jun 27, 2024
IamPete1
previously requested changes
Jul 1, 2024
muramura
force-pushed
the
AP_Add_a_MOUNT2_retract
branch
from
9c0487c
to
edaf4d3
Compare
IamPete1
reviewed
Jul 1, 2024
muramura
force-pushed
the
AP_Add_a_MOUNT2_retract
branch
2 times, most recently
from
848d896
to
97f8c4b
Compare
|
@IamPete1 san. I made changes. |
IamPete1
reviewed
Jul 1, 2024
muramura
force-pushed
the
AP_Add_a_MOUNT2_retract
branch
2 times, most recently
from
b2bc39d
to
6155e38
Compare
Update libraries/RC_Channel/RC_Channel.cpp Co-authored-by: Peter Hall <[email protected]>
muramura
force-pushed
the
AP_Add_a_MOUNT2_retract
branch
from
6155e38
to
cb9503f
Compare
|
@IamPete1 san. I agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rovers and other vehicles sometimes have cameras mounted on both the front and rear.