Copter: Remove Payload release on thrust loss detection (attempt2) #27396
+74
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
force-pushed
the
lthall-payload-release
branch
from
99bda29
to
d6b2584
Compare
lthall
approved these changes
Jun 27, 2024
tpwrules
requested changes
Jun 27, 2024
rmackay9
force-pushed
the
lthall-payload-release
branch
from
9df66ef
to
25df1a3
Compare
IamPete1
reviewed
Jul 1, 2024
IamPete1
reviewed
Jul 1, 2024
rmackay9
force-pushed
the
lthall-payload-release
branch
from
0ed1d0b
to
85d1a5f
Compare
|
OK, I'll switch this to use the aux function in order to save flash space. |
rmackay9
force-pushed
the
lthall-payload-release
branch
2 times, most recently
from
0c53aac
to
1455cc4
Compare
|
I've updated this to use the RC auxiliary function as discussed on the dev call and re-tested and I think it's working OK |
peterbarker
requested changes
Jul 3, 2024
| def GripperReleaseOnThrustLoss(self): | ||
| '''tests that gripper is released on thrust loss if option set''' | ||
|
|
||
| self.context_push() |
There was a problem hiding this comment.
We can retain this test - all we need to do is install_example_script_context here for your new script
|
@MattKear is going to review logs from the original customer. |
|
I have not been able to find logs from the original customer, so I am not going to stand in the way of this going in. Thanks for pausing this to give me chance to look. |
Co-authored-by: Iampete1 <[email protected]>
rmackay9
force-pushed
the
lthall-payload-release
branch
from
1455cc4
to
1c5e783
Compare
|
rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for PR #27339 and attempts to resolve the concerns raised with simply removing the option:
I've done some simple testing in SITL to confirm the arming check works
.. and to confirm that the new script does release the gripper on thrust loss or more accurately when these cases are true for a full second:
I tested by setting SIM_ENGINE_MUL = 0.6 which causes the quadcopter to lose altitude and hit the ground.
