Content-Length variable we use for sending update file needs to be case insensitive #27731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bugobliterator
commented
Aug 2, 2024
•
bugobliterator
commented
- also skip overriding SERIAL_ORDER in CubePilot-PPPGW
bugobliterator
force-pushed
the
pr-content-length-case-insensitive
branch
2 times, most recently
from
bfce81c
to
4ce2128
Compare
tridge
reviewed
Aug 14, 2024
Tools/AP_Bootloader/network.cpp
Outdated
| const uint32_t content_length = atoi(p); | ||
| const char *clen1 = "\r\nContent-Length:"; | ||
| const char *clen2 = "\r\ncontent-length:"; | ||
| const char *p1 = strstr(headers, clen1); |
There was a problem hiding this comment.
char *p = strstr(headers, clen);
if (p == nullptr) {
p = strstr(headers, clen2);
}
|
should remove the ECC change |
bugobliterator
force-pushed
the
pr-content-length-case-insensitive
branch
from
4ce2128
to
6eefd45
Compare
It's really strange to put this in the same PR. |
Otherwise will need to separate builds of Bootloaders. |
bugobliterator
force-pushed
the
pr-content-length-case-insensitive
branch
from
6eefd45
to
6b03b74
Compare
tridge
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.