-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARKV6X RC IN USART6 4.5 Backport #27736
ARKV6X RC IN USART6 4.5 Backport #27736
Conversation
@@ -81,7 +85,8 @@ PD9 USART3_RX USART3 | |||
|
|||
# USART6 is for IOMCU | |||
PC6 USART6_TX USART6 | |||
PC7 USART6_RX USART6 | |||
# used for RC SBUS | |||
#PC7 USART6_RX USART6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy to bring this in, but I'm curious why SBUS didn't work on this UART? Did the user set SERIAL8_PROTOCOL to RCIN?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @dakejahl - unanswered question here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversation is in a now deleted slack workspace but I think ultimately the issue ended up being the user had bad hardware. I can test again to be sure. Are there concerns with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conversation is in a now deleted slack workspace but I think ultimately the issue ended up being the user had bad hardware. I can test again to be sure. Are there concerns with this change?
I think tridge was just curious. He'll see your response as part of the backport process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not as familiar with ardupilot so if something doesn't look right let me know. Thanks for the review
this does seem a strange change, what testing has been done? |
I tested a few months ago and it was working. I can't remember everything I did and I can't seem to figure it out from the documentation. SBUS is not working at all for me using 4.5.5 or master (with or without this PR) SERIAL8_PROTOCOL set to RCIN Am I missing something? I even went back and tried 4.3.3 since this was when the board support was first introduced and SBUS worked back then (I checked the logs alex shared) but it's still not working. I am testing on a variant of this board with an IIM42653 IMU which does not yet have support in ardupilot, so I am getting a constant error about "failed to initialize INS", could this be interfering with the SBUS setup somehow? I know the hardware is working because when I flash to PX4 it works. |
Closing per directions in #28015 |
I've removed the 4.5 backport project because it doesn't look like we want to do that |
Backport of @dakejahl work in master to fix SBUS input on the RC IN port.