Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARKV6X RC IN USART6 4.5 Backport #27736

Conversation

AlexKlimaj
Copy link
Contributor

@AlexKlimaj AlexKlimaj commented Aug 2, 2024

Backport of @dakejahl work in master to fix SBUS input on the RC IN port.

@@ -81,7 +85,8 @@ PD9 USART3_RX USART3

# USART6 is for IOMCU
PC6 USART6_TX USART6
PC7 USART6_RX USART6
# used for RC SBUS
#PC7 USART6_RX USART6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to bring this in, but I'm curious why SBUS didn't work on this UART? Did the user set SERIAL8_PROTOCOL to RCIN?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @dakejahl - unanswered question here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversation is in a now deleted slack workspace but I think ultimately the issue ended up being the user had bad hardware. I can test again to be sure. Are there concerns with this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversation is in a now deleted slack workspace but I think ultimately the issue ended up being the user had bad hardware. I can test again to be sure. Are there concerns with this change?

I think tridge was just curious. He'll see your response as part of the backport process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with ardupilot so if something doesn't look right let me know. Thanks for the review

@tridge
Copy link
Contributor

tridge commented Aug 21, 2024

this does seem a strange change, what testing has been done?

@tridge tridge removed the DevCallEU label Aug 28, 2024
@dakejahl
Copy link
Contributor

I tested a few months ago and it was working. I can't remember everything I did and I can't seem to figure it out from the documentation. SBUS is not working at all for me using 4.5.5 or master (with or without this PR)

SERIAL8_PROTOCOL set to RCIN
RC_PROTOCOL set to 1 (all)

Am I missing something?

I even went back and tried 4.3.3 since this was when the board support was first introduced and SBUS worked back then (I checked the logs alex shared) but it's still not working.
#21865

I am testing on a variant of this board with an IIM42653 IMU which does not yet have support in ardupilot, so I am getting a constant error about "failed to initialize INS", could this be interfering with the SBUS setup somehow?

I know the hardware is working because when I flash to PX4 it works.

@peterbarker
Copy link
Contributor

Closing per directions in #28015

@peterbarker peterbarker closed this Sep 5, 2024
@rmackay9
Copy link
Contributor

I've removed the 4.5 backport project because it doesn't look like we want to do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants