Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Notify: allow split-standard LED pattern on serial LEDs #27829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andyp1per
Copy link
Collaborator

This is a simple little change that allows serial LED strips to easily be used as navigation / orientation lights. Drone registration in Japan appears to be requiring orientation indicators and this is an easy way to comply - either through a single strip or strips mounted on the arms. The change itself splits the LEDs into two banks, the first half shows the normal colours and the second swaps red and green so that when armed you get half red and half green.

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is really too much of a hack, its going to confuse everyone. Flashing green means I'm good to arm, except if I'm looking from the back in which case its flashing red? If I loose GPS fix then it all goes blue so I can no longer tell orientation at all?

Scripting really is great for such things.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Aug 14, 2024
@andyp1per
Copy link
Collaborator Author

I think this is really too much of a hack, its going to confuse everyone. Flashing green means I'm good to arm, except if I'm looking from the back in which case its flashing red? If I loose GPS fix then it all goes blue so I can no longer tell orientation at all?

Scripting really is great for such things.

Scripting is not good in this use case for three reasons:

a) All the copters I need this on (small copters) don't have scripting
b) To implement in scripting you have to re-implement the whole of the notify standard patterns - complicated and laborious
c) It's a pretty standard requirement and becoming more so legally

The confusion thing could be addressed by an armed only flag - so "Show navigation colours on arming".

@IamPete1
Copy link
Member

IamPete1 commented Aug 14, 2024

b) To implement in scripting you have to re-implement the whole of the notify standard patterns - complicated and laborious

We have a binding to return the current notify color. LED:get_rgb() So you can mirror notify, or output notify colors on a subsection. I can't find a example vid of that, but this is this is our Hexsoon example script: https://youtu.be/X-kGiXX4AKU?si=OivIGhDyzKOcfvSa&t=1226

Edit: I found the notify demo https://youtu.be/qHUIMvzoF10

@tridge tridge removed the DevCallEU label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants