Copter: remove global ap.new_radio_frame state #28355
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have better means to determine if you have valid input
peterbarker
force-pushed
the
pr/remove-new-radio-frame-state
branch
from
921a778
to
b0c800f
Compare
peterbarker
commented
Nov 8, 2024
| // mark radio frame as consumed | ||
| ap.new_radio_frame = false; | ||
| // exit immediately if RC input is invalid: | ||
| if (!rc().has_valid_input()) { |
There was a problem hiding this comment.
This is not the same; RC input would come in at maybe 50Hz, this method is called at the main loop rate, so we'd start to do these transforms much faster than required in the case someone's using simple mode. The method is also not idempotent, so pretty much completely broken.
We probably want to unconditionally call this method when a new radio frame is received instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have better means to determine if you have valid input
Rebase/push after #28354 is merged - in the meantime only the most recent patch is interesting