-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Bootloader: reserve board ids and range for Karshak Drones #28518
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should request a range in the higher numbers where we have done other vendors
@andyp1per - I changed the IDs from 188-211 to 4000-4040. Please check and let me know if you need me to make any other required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Higher values for IDs are used. Please check and let me know if any further changes are needed. Thank You.
I've:
Marking as MergeOnCIPass now. Note that you might look at using "topic branches" for doing code changes on: https://ardupilot.org/dev/docs/git-branch.html . Using your master branch for creating PRs isn't a great workflow! |
Thank You, Mr. Peter Barker.
This is my first time creating a pull request to a public repository, thank you for pointing it out. I'm in the learning phase. I'll look into the hyperlink that you shared and learn. |
This commit is to reserve the available board ids within the given range
This commit reserves the available board IDs within the given range of 189 to 211 for Karshak Drones. Changes are introduced after line 112 of the file board_types.txt, which is placed under Tools/AP_Bootloader/board_types.txt.