Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RC_Channel to populate IOMCU mappings #28565

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

peterbarker
Copy link
Contributor

Bench-tested using an OrangeRX and a CubeOrangePlus and a servo. All seems right compared to master.

Board,plane
CubeOrangePlus,-32

@amilcarlucas
Copy link
Contributor

How close are we to remove RC_MAP ?

@peterbarker
Copy link
Contributor Author

How close are we to remove RC_MAP ?

I think my die-rcmap-die branch shows most of that. Parameter conversion, scripting binding changes and simulink changes.

The other big thing is GCS adjustment. QGC is going to require some surgery to understand RCn_OPTION 201 means roll, that sort of thing, rather than looking at RCMAP_ROLL, likewise with MissionPlanner. I'd imagine several closed-source GCSs would also need updating. These GCSs will need to understand both mechanisms for several years, of course.

I'm wondering about some interim arrangement whereby we magically update the RCMAP parameters from the RCn_OPTION parameters and vice-versa, throwing a warning when we update RCn_OPTION from RCMAP.

@IamPete1
Copy link
Member

I'm wondering about some interim arrangement whereby we magically update the RCMAP parameters from the RCn_OPTION parameters and vice-versa, throwing a warning when we update RCn_OPTION from RCMAP.

We could make RCMAP read only, so legacy GCSs can still show the correct thing on there RC calibration screen. I'm not sure if any try and change them, Mission Planner doesn't as far as I know.

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tridge tridge merged commit 2ad8477 into ArduPilot:master Nov 12, 2024
99 checks passed
@peterbarker peterbarker deleted the pr/iomcu-no-rcmap branch November 12, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants