AP_VideoTX: Fix _configuration_finished indication for Tramp VTX #28584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this change on my setup SpeedyBee F405 Wing Mini + HGLRC Zeus Nano VTX VTX_PWR starts blinking when I change VTX Power via RC Switch and stops blinking one second later. |
The flag _configuration_finished in AP_VideoTX is not set by AP_Tramp. Therefore OSD item VTX_PWR blinks forever.
menschel
force-pushed
the
trampbugfix
branch
from
d2f6c33
to
9377e69
Compare
|
Rebased on Master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a minor bug in the Tramp VTX status propagation.
The flag
_configuration_finishedin class AP_VideoTX is not set by AP_Tramp class.Therefore VTX Power blinks in OSD forever.