Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for CubeNode ETH #28615

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Fix build for CubeNode ETH #28615

merged 2 commits into from
Nov 15, 2024
+5 −0

Conversation

bugobliterator
Copy link
Member

@bugobliterator bugobliterator commented Nov 14, 2024 •
edited
Loading

  • build was broken as a mandatory virtual method was added under GCS_MAVLink, without update AP_Periph/GCS_Mavlink
  • also adds CubeNode-ETH to the CI to ensure that we have a periph firmware built with GCS_MAVLink and scripting enabled.

peterbarker
peterbarker approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker
Copy link
Contributor

Note the commit message should be Tools: rather than .github: but I can't bring myself to require it :-)

@peterbarker peterbarker merged commit 44ef597 into ArduPilot:master Nov 15, 2024
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

@tridge tridge Awaiting requested review from tridge

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugobliterator @peterbarker