Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Network/AP_DDS: default IP address to 192.168.144.x #28815

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Dec 6, 2024

I suspect people won't like this change because it is a break changing to existing setups. Still, I think it's early enough that we could change the default IP address without upsetting too many people as long as we do it as part of a major release (e.g. 4.6).

While I know there will be push back on this change, I really would like it if those pushing back consider usability and how we can make things easier for users. It's easy to say, "no", it's more difficult to think of ways to make things better

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 6, 2024

Why is 144 better than 13?

@timtuxworth
Copy link
Contributor

timtuxworth commented Dec 6, 2024

Why is 144 better than 13?

It seems that that most existing ethernet equipped devices that can connect to ArduPilot seem to have settled on the 192.168.144 subnet. It seems the HereLink may have set the precedent and there are now a number of other devices such as gimbal/cameras and AI modules from companies like SiYi and TopoTek that are all using 144 addresses. There's some good background here https://ardupilot.org/plane/docs/common-ethernet-vehicle.html

This is going to be one of the first things that I and others will want to do - connect the AP to a BotBlox switch, either using the PPP interface or ethernet. ArduPilot will need to communicate with one or more gimbal/cameras, AI module and ROS2/DDS and other services running on a companion computer, using the same physical port on the AP.

This is a lot easier to do if the devices can use their "out of the box" configured 192.168.144.* IP addresses, with the only interface needing to be configured being the ethernet port on the companion computer.

This is why I previously suggested that DDS should not be doing it's own networking - it should use the IP addresses configured in the NET* parameters and should be able to run as a NET_Pn_PROTOCOL, so all these devices can be connected over a single physical port to the AP.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Dec 6, 2024

I'm fine with this change if there's a convention. Our DDS users that use Ethernet understand networking and we have good log messages already.

Tim - please file a new issue if you have concerns. We are using direct access to the network stack for a few reasons, and we need convincing performance data to remove that support.

@timtuxworth
Copy link
Contributor

Tim - please file a new issue if you have concerns. We are using direct access to the network stack for a few reasons, and we need convincing performance data to remove that support.

#28819

@CraigElder CraigElder changed the title AP_Netork/AP_DDS: default IP address to 192.168.144.x AP_Network/AP_DDS: default IP address to 192.168.144.x Dec 9, 2024
@tridge tridge merged commit ec215c3 into ArduPilot:master Dec 9, 2024
99 checks passed
@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Dec 9, 2024
@rmackay9 rmackay9 deleted the network-ip-default branch December 10, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.6.0-beta2
Development

Successfully merging this pull request may close these issues.

6 participants