feat(sessions): add trace latency p50 to session details #5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
RogerHYang
approved these changes
Oct 30, 2024
RogerHYang
reviewed
Oct 30, 2024
dosubot
bot
added
size:L
|
LGTM. Nice work! |
RogerHYang
approved these changes
Oct 31, 2024
RogerHYang
reviewed
Oct 31, 2024
src/phoenix/server/api/dataloaders/session_trace_latency_ms_quantile.py
Outdated
Show resolved
Hide resolved
RogerHYang
reviewed
Oct 31, 2024
RogerHYang
reviewed
Oct 31, 2024
RogerHYang
reviewed
Oct 31, 2024
|
Can you also add a small test to this file? A minimal one will suffice. Thanks. |
done! |
…aphql trace_latency_ms_quantile field
RogerHYang
pushed a commit
that referenced
this pull request
Oct 31, 2024
* feat(sessions): add trace latency p50 to session details * fix type for latency in ui * update test, fix where clause * add is not none check for db filter * revert latency dataloader changes * revert dataloader changes for project span and trace latency * refactor to use its own data loader * remove extra param from test * add unit tests * ruff * fix import * fix name filter in other dataloader tests * update unit test fixture naming, add unit test for project session graphql trace_latency_ms_quantile field * clean up imports * pin aiohttp * fix unit test deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5232