feat(ia-epic): Adjustments to Menu for Information Architecture UI

[ronchambers]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This code helps to complete Asana Task: "Newspack Information Architecture > IA Listings".

See the primary PR here: Automattic/newspack-plugin#3483

The code in this PR does 3 things:

1. It adds a helpful note above a callback function to alert future developers that the callback function might be removed via remove_action by the "parent" Newspack Plugin. This could be helpful to know if a developer isn't seeing the correct output from the callback they expect.

2. It adds a "todo" that recommends we remove the Category and Tag links since they just link to the normal Posts categories and tags anyway. This isn't needed in the main PR above, but in an effort to possibly "clean up" the plugin a bit, since it's getting cleaned up via the Information Architecture (IA) project anyway :-)

3. The final change, is the one that I highly recommend we do. It will make the code in the main PR above easier. The change here is to move "Marketplace Listings" above "Generic Listings". In the IA project it was deemed that Marketplace should go above Generic. So my recommendation is to do a little "clean up" in the Listings plugin now and move Marketplace above Generic :-)

Screenshot:

How to test the changes in this Pull Request:

1. Pull this branch.
2. View the menu in wp-admin.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[ronchambers]

@miguelpeixe - please see above. I'll assign you in Asana and reach out in Slack.

[miguelpeixe]

Thanks, @ronchambers!

Changes look good and are consistent with what IA proposes. I agree we don't need duplicate taxonomy links here, so I went ahead and pushed 5b23399.

[miguelpeixe]

Suggested change

// Move Marketplace above Generic here so that admin submenu will show Marketplace above Generic.

I don't think this comment is necessary.

[ronchambers]

Thanks @miguelpeixe for removing the category/tax links. As for the comment // Move Marketplace above Generic ... I agree the comment can be removed. I put it there because "everywhere else" in the plugin Generic is coded above Marketplace. But I'm totally cool with whatever you decide :-)