-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ia-listings): IA for Listings Plugin #3483
base: epic/ia
Are you sure you want to change the base?
Conversation
@miguelpeixe - please see above. I'll assign you in Asana and reach out in Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It tested well! I have just a minor request inline.
@jaredrethman I've pushed some changes to accommodate the recent refactor to the menu order logic. Could you review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miguelpeixe thanks for the review, only thing missing is active submenu when add/edit post types i.e:
/wp-admin/post-new.php?post_type=newspack_lst_*
/wp-admin/post.php?post=POST_ID
All Submissions:
Changes proposed in this Pull Request:
This code completes Asana Task: "Newspack Information Architecture > IA Listings".
Screenshot of Menu:
Screenshot of Dashboard:
How to test the changes in this Pull Request:
npm run build
Note about Related PR:
The code to move the submenu link for Marketplace above Generic is done in the Listings Plugin. ( SEE RELATED: Automattic/newspack-listings#487 )
If we are unable to approve that PR, then we'll need to approve this PR keeping Generic above Marketplace (this is how Listings Plugin does it already), or we'll need to update this PR with a solution.
Other information: