epic: consolidate newsletter editor data and UI #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: autocomplete "Send To" UI for CC + AC * fix: sent post statuses for AC * feat: autocomplete send-to UI for Mailchimp * fix: support _n() contacts in AC + CC * refactor: standardize "sent" status checks for all ESPs * fix: function name for CC * fix: set list_type for audiences * fix: extra parentheses for AC * feat: show suggestions on focus * style: move external "Manage" links to button * feat: design updates for autocomplete UI * fix: send to summary * fix: contact counts in send to summary * fix: mailchimp and selected list styles * fix: remove ID from AC segments * fix: logic for contact count in send to summary * fix: parse contact counts as int to avoid "1 contacts" output * fix: translation strings for contact counts in summaries * refactor: standardize use of renderSelectedSummary functions * fix: translatable send-to summaries * fix: allow 0 to be shown * fix: grammar * Update src/service-providers/active_campaign/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/active_campaign/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/constant_contact/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/constant_contact/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/mailchimp/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * Update src/service-providers/mailchimp/ProviderSidebar.js Co-authored-by: leogermani <[email protected]> * fix: translatable strings in SendTo component’s selected item label --------- Co-authored-by: leogermani <[email protected]>
* feat: cross-ESP send-lists * refactor: move API namespace and permission callback to main class * refactor: feedback from code review * fix: add missing get/set methods for count and parent_id * refactor: more consistent naming for set_count method * refactor: maintain exception but with WP_Error handling * docs: add more explanation about Send_Lists Co-authored-by: leogermani <[email protected]> * test: improve tests for matching methods * refactor: set values on protected $config var * docs: tweak wording of explanation --------- Co-authored-by: leogermani <[email protected]>
* feat: cross-ESP send-lists * refactor: move API namespace and permission callback to main class * feat: support send lists in provider classes * fix: use getter methods for Send_List classes * chore: clean up register_rest_route configs and permission callbacks * fix: improve error handling for get_send_list methods * fix: add error handling to send-lists API handler
…rays instead of objects" This reverts commit 3ff1e65.
refactor: consolidate ESP data getters into Redux store
…-lists fix: default sender/send-to for saved layouts BREAKING CHANGE: Existing custom layouts with sender or send-to settings will need to be reconfigured and resaved with desired settings.
github-actions
bot
added
[Status] Approved
6 tasks
leogermani
changed the title
* fix: handle legacy layout defaults for MC * fix: legacy layout defaults for AC + CC * fix: senderName + senderEmail for AC
|
🎉 This PR is included in version 3.2.1-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Oct 14, 2024
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR contains changes from #1629, #1630, #1631, and #1632 which were already tested and code reviewed, so it should only require a quick review of the changeset instead of a full code review.
How to test the changes in this Pull Request:
If anything, just ensure that the newsletter editor loads correctly and lets you select/save sender and send list info without any fatals.
Other information: