Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic: consolidate newsletter editor data and UI #1658

Merged
merged 54 commits into from
Oct 14, 2024
Merged

epic: consolidate newsletter editor data and UI #1658

merged 54 commits into from
Oct 14, 2024

Commits on Aug 2, 2024

  1. feat: make "Send To" UI autocomplete instead of dropdowns (#1577) 

    * feat: autocomplete "Send To" UI for CC + AC

* fix: sent post statuses for AC

* feat: autocomplete send-to UI for Mailchimp

* fix: support _n() contacts in AC + CC

* refactor: standardize "sent" status checks for all ESPs

* fix: function name for CC

* fix: set list_type for audiences

* fix: extra parentheses for AC

* feat: show suggestions on focus

* style: move external "Manage" links to button

* feat: design updates for autocomplete UI

* fix: send to summary

* fix: contact counts in send to summary

* fix: mailchimp and selected list styles

* fix: remove ID from AC segments

* fix: logic for contact count in send to summary

* fix: parse contact counts as int to avoid "1 contacts" output

* fix: translation strings for contact counts in summaries

* refactor: standardize use of renderSelectedSummary functions

* fix: translatable send-to summaries

* fix: allow 0 to be shown

* fix: grammar

* Update src/service-providers/active_campaign/ProviderSidebar.js

Co-authored-by: leogermani <[email protected]>

* Update src/service-providers/active_campaign/ProviderSidebar.js

Co-authored-by: leogermani <[email protected]>

* Update src/service-providers/constant_contact/ProviderSidebar.js

Co-authored-by: leogermani <[email protected]>

* Update src/service-providers/constant_contact/ProviderSidebar.js

Co-authored-by: leogermani <[email protected]>

* Update src/service-providers/mailchimp/ProviderSidebar.js

Co-authored-by: leogermani <[email protected]>

* Update src/service-providers/mailchimp/ProviderSidebar.js

Co-authored-by: leogermani <[email protected]>

* fix: translatable strings in SendTo component’s selected item label

---------

Co-authored-by: leogermani <[email protected]>
    @dkoo @leogermani
    dkoo and leogermani authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1371bac View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c83f3b2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    7a43381 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @miguelpeixe
    miguelpeixe committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a4bbe2a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. fix(editor): render notice on sync error (#1606)

    @miguelpeixe
    miguelpeixe authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0762860 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. fix(mailchimp): improve sync error messages (#1619)

    @miguelpeixe
    miguelpeixe authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7bc6ff5 View commit details
    Browse the repository at this point in the history

  2. fix(activecampaign): default message on request error (#1618)

    @miguelpeixe
    miguelpeixe authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    612741e View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6936113 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @miguelpeixe
    miguelpeixe committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f07b7b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    05c1e23 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. feat: cross-ESP send-lists

    @dkoo
    dkoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2df6fef View commit details
    Browse the repository at this point in the history

  2. refactor: move API namespace and permission callback to main class

    @dkoo
    dkoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7c0d36a View commit details
    Browse the repository at this point in the history

  3. feat: support send lists in provider classes

    @dkoo
    dkoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    92b3348 View commit details
    Browse the repository at this point in the history

  4. feat: refactor editor JS to use new standardized data

    @dkoo
    dkoo committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b729290 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. fix: ensure Newsletters plugin blocks are grouped under Newspack cate… 

    …gory (#1630)
    @dkoo
    dkoo authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    93dc8c5 View commit details
    Browse the repository at this point in the history

  2. feat: send list classes (#1629) 

    * feat: cross-ESP send-lists

* refactor: move API namespace and permission callback to main class

* refactor: feedback from code review

* fix: add missing get/set methods for count and parent_id

* refactor: more consistent naming for set_count method

* refactor: maintain exception but with WP_Error handling

* docs: add more explanation about Send_Lists

Co-authored-by: leogermani <[email protected]>

* test: improve tests for matching methods

* refactor: set values on protected $config var

* docs: tweak wording of explanation

---------

Co-authored-by: leogermani <[email protected]>
    @dkoo @leogermani
    dkoo and leogermani authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    00006cd View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5a44389 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. feat: support send lists in ESP classes (#1631) 

    * feat: cross-ESP send-lists

* refactor: move API namespace and permission callback to main class

* feat: support send lists in provider classes

* fix: use getter methods for Send_List classes

* chore: clean up register_rest_route configs and permission callbacks

* fix: improve error handling for get_send_list methods

* fix: add error handling to send-lists API handler
    @dkoo
    dkoo authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1ed1e50 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ada9d71 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'epic/update-editor-uis' into feat/send-lists-editor-js

    @dkoo
    dkoo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    de61ff9 View commit details
    Browse the repository at this point in the history

  2. fix: return Send_List objects as arrays from provider methods

    @dkoo
    dkoo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c7fc917 View commit details
    Browse the repository at this point in the history

  3. fix: avoid unnecessary send-list API requests

    @dkoo
    dkoo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3d3430c View commit details
    Browse the repository at this point in the history

  4. chore: remove unneeded methods

    @dkoo
    dkoo committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0b530bc View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. fix: fatal error due to get_send_lists returning Send_List arrays ins… 

    …tead of objects
    @dkoo
    dkoo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3ff1e65 View commit details
    Browse the repository at this point in the history

  2. Revert "fix: fatal error due to get_send_lists returning Send_List ar… 

    …rays instead of objects"

This reverts commit 3ff1e65.
    @dkoo
    dkoo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1f302c3 View commit details
    Browse the repository at this point in the history

  3. fix: allow get_send_list methods to return either Send_List[] or arrays

    @dkoo
    dkoo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7a48870 View commit details
    Browse the repository at this point in the history

  4. fix: correct type for supportedESPs fallback value

    @dkoo
    dkoo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    be52969 View commit details
    Browse the repository at this point in the history

  5. fix(mc): subscriber send count in pre-send modal summary

    @dkoo
    dkoo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3ffcd6b View commit details
    Browse the repository at this point in the history

  6. fix: formatting error

    @dkoo
    dkoo committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a22b721 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. fix: ensure supported_esps is an array, not an object

    @dkoo
    dkoo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c00aca5 View commit details
    Browse the repository at this point in the history

  2. fix: missed callable

    @dkoo
    dkoo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a43989c View commit details
    Browse the repository at this point in the history

  3. fix: cc error handling

    @miguelpeixe
    miguelpeixe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6f85a8b View commit details
    Browse the repository at this point in the history

  4. fix: better error handling for retrieve/sync request errors

    @dkoo
    dkoo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f5555c2 View commit details
    Browse the repository at this point in the history

  5. refactor: unify retrieve error handling across all ESPs

    @dkoo
    dkoo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5627680 View commit details
    Browse the repository at this point in the history

  6. refactor: throw error for missing MC creds, too

    @dkoo
    dkoo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    399cc89 View commit details
    Browse the repository at this point in the history

  7. test: update expected exception message

    @dkoo
    dkoo committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    55a7d7f View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge pull request #1632 from Automattic/feat/send-lists-editor-js 

    feat: refactor editor JS to use new standardized data
    @dkoo
    dkoo authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d7ef0c8 View commit details
    Browse the repository at this point in the history

  2. refactor: consolidate ESP data getters into Redux store

    @dkoo
    dkoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    decefdb View commit details
    Browse the repository at this point in the history

  3. docs: update inline docs for Redux store

    @dkoo
    dkoo committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bf8b204 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5a43634 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'epic/update-editor-uis' into fix/store-improvements

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    26247f9 View commit details
    Browse the repository at this point in the history

  3. fix: move SendTo to Sidebar component; avoid parallel retrieve requests

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6c82b6e View commit details
    Browse the repository at this point in the history

  4. refactor: always prefetch sublists on list select

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    2a28758 View commit details
    Browse the repository at this point in the history

  5. fix: account for missing selected list or sublist info

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    a8e10da View commit details
    Browse the repository at this point in the history

  6. fix: default sender/send-to for saved layouts

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b27a3c0 View commit details
    Browse the repository at this point in the history

  7. fix: campaign_defaults meta field name

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    919a4d0 View commit details
    Browse the repository at this point in the history

  8. fix: don't overwrite fetched lists/sublists info on retrieve

    @dkoo
    dkoo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b27f195 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge pull request #1657 from Automattic/fix/store-improvements 

    refactor: consolidate ESP data getters into Redux store
    @dkoo
    dkoo authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    999829f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'epic/update-editor-uis' into fix/layout-defaults-for-se… 

    …nd-lists
    @dkoo
    dkoo authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2e7497e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1633 from Automattic/fix/layout-defaults-for-send… 

    …-lists

fix: default sender/send-to for saved layouts

BREAKING CHANGE: Existing custom layouts with sender or send-to settings will need to be reconfigured and resaved with desired settings.
    @dkoo
    dkoo authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4fb1e4c View commit details
    Browse the repository at this point in the history

  4. fix: force release

    @dkoo
    dkoo committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9657be1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. feat: add link to campaign in provider (#1661)

    @miguelpeixe
    miguelpeixe authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    44f3118 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'trunk' into epic/update-editor-uis

    @dkoo
    dkoo committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c83ffa4 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix: parse legacy layout defaults (#1663) 

    * fix: handle legacy layout defaults for MC

* fix: legacy layout defaults for AC + CC

* fix: senderName + senderEmail for AC
    @dkoo
    dkoo authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    25a9e2d View commit details
    Browse the repository at this point in the history