Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display list remote name on settings page #1672

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Oct 15, 2024

All Submissions:

Changes proposed in this Pull Request:

Displays the List's remote name on the settings page and expose it in the API. This makes sure the user will always see the name that is set on the remote ESP in their list.

How to test the changes in this Pull Request:

  1. Configure Newsletters with an ESP with several lists
  2. Visit Newsletters > Settings and make sure you see al the lists there
  3. Make sure you have at least two lists that comes from the ESP (for example 2 mailchimp groups)
  4. On Newsletters > Settings, customize the title of one of those lists
  5. Go to the ESP dashboard and rename one of the lists
  6. Back to the site, make sure you see the updated name in the Settings page
  7. Confirm that the customizable title was updated only in the list that was not edited before. The list for which you had set up a custom title remained with the old title
  8. Checkout feat: display list remote name on newsletter wizard newspack-plugin#3478 and go to Newspack > Engagement > Newsletters
  9. Confirm the same behavior there

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 20.16%. Comparing base (bcf221f) to head (8d0a772).
Report is 8 commits behind head on trunk.

Files with missing lines Patch % Lines
includes/class-newspack-newsletters-settings.php 0.00% 1 Missing ⚠️
includes/class-subscription-list.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #1672      +/-   ##
============================================
- Coverage     20.74%   20.16%   -0.59%     
- Complexity     2410     2413       +3     
============================================
  Files            46       46              
  Lines          9075     9895     +820     
============================================
+ Hits           1883     1995     +112     
- Misses         7192     7900     +708     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leogermani leogermani merged commit 562d396 into trunk Oct 23, 2024
10 checks passed
@leogermani leogermani deleted the feat/display-remote-name branch October 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants