feat: display list remote name on newsletter wizard #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
leogermani
added
the
[Status] Needs Review
adekbadek
approved these changes
Oct 23, 2024
github-actions
bot
added
[Status] Approved
dkoo
approved these changes
Oct 23, 2024
leogermani
commented
Oct 23, 2024
| @@ -352,8 +352,7 @@ export const SubscriptionLists = ( { lockedLists, onUpdate, initialProvider } ) | |||
| isSmall | |||
| simple | |||
| hasWhiteHeader | |||
| title={ list.name } | |||
| description={ list?.type_label ? list.type_label : null } | |||
There was a problem hiding this comment.
wait, I think deleting the descriptionwas an accident @dkoo @adekbadek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Correctly displays the list "remote name" (the name set in the ESP) in the Newsletters wizard
How to test the changes in this Pull Request:
See Automattic/newspack-newsletters#1672
Other information: