Fixes #132 #133
Merged
Fixes #132 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 152 152
Lines 20194 20196 +2
Branches 3336 3336
=======================================
+ Hits 14455 14457 +2
Misses 4909 4909
Partials 830 830
☔ View full report in Codecov by Sentry. |
Merged
I am unsure why you saw the error... I tested it for the same and works fine. This fix alleviates the orthogonality error. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #132, but was not able to run the attached example to verify