Skip to content

Commit

Permalink
Fix lint error
Browse files Browse the repository at this point in the history
  • Loading branch information
NereusWB922 committed Mar 14, 2024
1 parent b7d422e commit da6cc25
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 16 deletions.
2 changes: 1 addition & 1 deletion src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ import { GithubEventService } from './core/services/githubevent.service';
import { IssueService } from './core/services/issue.service';
import { LabelService } from './core/services/label.service';
import { LoggingService } from './core/services/logging.service';
import { ViewService } from './core/services/view.service';
import { RepoSessionStorageService } from './core/services/repo-session-storage.service';
import { UserService } from './core/services/user.service';
import { ViewService } from './core/services/view.service';
import { IssuesViewerModule } from './issues-viewer/issues-viewer.module';
import { LabelDefinitionPopupComponent } from './shared/label-definition-popup/label-definition-popup.component';
import { HeaderComponent } from './shared/layout';
Expand Down
2 changes: 1 addition & 1 deletion src/app/auth/auth.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { AuthService, AuthState } from '../core/services/auth.service';
import { ErrorHandlingService } from '../core/services/error-handling.service';
import { ErrorMessageService } from '../core/services/error-message.service';
import { LoggingService } from '../core/services/logging.service';
import { ViewService } from '../core/services/view.service';
import { UserService } from '../core/services/user.service';
import { ViewService } from '../core/services/view.service';

@Component({
selector: 'app-auth',
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/models/session.model.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { pipe } from 'rxjs';
import { throwIfFalse } from '../../shared/lib/custom-ops';
import { View } from './view.model';
import { Repo } from './repo.model';
import { View } from './view.model';

/**
* Session repository comprises the view and its corresponding repository array.
Expand Down
5 changes: 2 additions & 3 deletions src/app/core/services/auth.service.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Injectable } from '@angular/core';
import { NgZone } from '@angular/core';
import { Injectable, NgZone } from '@angular/core';
import { Title } from '@angular/platform-browser';
import { Router, RouterStateSnapshot } from '@angular/router';
import { BehaviorSubject, from, Observable, of } from 'rxjs';
Expand All @@ -14,8 +13,8 @@ import { GithubEventService } from './githubevent.service';
import { IssueService } from './issue.service';
import { LabelService } from './label.service';
import { LoggingService } from './logging.service';
import { ViewService } from './view.service';
import { UserService } from './user.service';
import { ViewService } from './view.service';

export enum AuthState {
'NotAuthenticated',
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/services/factories/factory.auth.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { IssueService } from '../issue.service';
import { LabelService } from '../label.service';
import { LoggingService } from '../logging.service';
// import { MockAuthService } from '../mocks/mock.auth.service';
import { ViewService } from '../view.service';
import { UserService } from '../user.service';
import { ViewService } from '../view.service';

export function AuthServiceFactory(
router: Router,
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/services/factories/factory.issue.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import { GithubService } from '../github.service';
import { IssueService } from '../issue.service';
// import { MockIssueService } from '../mocks/mock.issue.service';
import { ViewService } from '../view.service';
import { UserService } from '../user.service';
import { ViewService } from '../view.service';

export function IssueServiceFactory(githubService: GithubService, userService: UserService, viewService: ViewService) {
// TODO: Write Mocks
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/services/issue.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import { GithubIssue } from '../models/github/github-issue.model';
import { Issue, Issues, IssuesFilter } from '../models/issue.model';
import { View } from '../models/view.model';
import { GithubService } from './github.service';
import { ViewService } from './view.service';
import { UserService } from './user.service';
import { ViewService } from './view.service';

@Injectable({
providedIn: 'root'
Expand Down
2 changes: 1 addition & 1 deletion src/app/core/services/view.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { Router } from '@angular/router';
import { BehaviorSubject, Observable, of, Subject } from 'rxjs';
import { map } from 'rxjs/operators';
import { STORAGE_KEYS } from '../constants/storage-keys.constants';
import { View } from '../models/view.model';
import { Repo } from '../models/repo.model';
import { SessionData } from '../models/session.model';
import { View } from '../models/view.model';
import { ErrorMessageService } from './error-message.service';
import { GithubService } from './github.service';
import { LoggingService } from './logging.service';
Expand Down
4 changes: 2 additions & 2 deletions src/app/shared/layout/header.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import { Observable } from 'rxjs';
import { filter, pairwise, switchMap } from 'rxjs/operators';
import { AppConfig } from '../../../environments/environment';
import { STORAGE_KEYS } from '../../core/constants/storage-keys.constants';
import { View } from '../../core/models/view.model';
import { Repo } from '../../core/models/repo.model';
import { View } from '../../core/models/view.model';
import { AuthService } from '../../core/services/auth.service';
import { DialogService } from '../../core/services/dialog.service';
import { ErrorHandlingService } from '../../core/services/error-handling.service';
Expand All @@ -16,10 +16,10 @@ import { GithubEventService } from '../../core/services/githubevent.service';
import { IssueService } from '../../core/services/issue.service';
import { LabelService } from '../../core/services/label.service';
import { LoggingService } from '../../core/services/logging.service';
import { ViewDescription, ViewService } from '../../core/services/view.service';
import { RepoSessionStorageService } from '../../core/services/repo-session-storage.service';
import { RepoUrlCacheService } from '../../core/services/repo-url-cache.service';
import { UserService } from '../../core/services/user.service';
import { ViewDescription, ViewService } from '../../core/services/view.service';

const ISSUE_TRACKER_URL = 'https://github.com/CATcher-org/WATcher/issues';

Expand Down
2 changes: 1 addition & 1 deletion tests/app/core/models/session-model.spec.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { of } from 'rxjs';
import { View } from '../../../../src/app/core/models/view.model';
import {
assertSessionDataIntegrity,
NO_VALID_OPEN_VIEWS,
OPENED_VIEW_REPO_UNDEFINED,
SESSION_DATA_MISSING_FIELDS,
SESSION_DATA_UNAVAILABLE
} from '../../../../src/app/core/models/session.model';
import { View } from '../../../../src/app/core/models/view.model';
import { VALID_SESSION_DATA, WATCHER_REPO } from '../../../constants/session.constants';

describe('Session Model', () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/constants/session.constants.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { View } from '../../src/app/core/models/view.model';
import { Repo } from '../../src/app/core/models/repo.model';
import { SessionData, SessionRepo } from '../../src/app/core/models/session.model';
import { View } from '../../src/app/core/models/view.model';

export const WATCHER_REPO: Repo = Repo.of('CATcher-org/WATcher');
export const CATCHER_REPO: Repo = Repo.of('CATcher-org/CATcher');
Expand Down
4 changes: 2 additions & 2 deletions tests/services/view.service.spec.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { Router } from '@angular/router';
import { of } from 'rxjs';
import { STORAGE_KEYS } from '../../src/app/core/constants/storage-keys.constants';
import { View } from '../../src/app/core/models/view.model';
import { Repo } from '../../src/app/core/models/repo.model';
import { View } from '../../src/app/core/models/view.model';
import { ErrorMessageService } from '../../src/app/core/services/error-message.service';
import { GithubService } from '../../src/app/core/services/github.service';
import { LoggingService } from '../../src/app/core/services/logging.service';
import { ViewService } from '../../src/app/core/services/view.service';
import { RepoUrlCacheService } from '../../src/app/core/services/repo-url-cache.service';
import { ViewService } from '../../src/app/core/services/view.service';
import { CATCHER_REPO, WATCHER_REPO } from '../constants/session.constants';

let viewService: ViewService;
Expand Down

0 comments on commit da6cc25

Please sign in to comment.