Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology-Enhanced Search #487

Closed
zhouji2013 opened this issue May 17, 2021 · 14 comments
Closed

Ontology-Enhanced Search #487

zhouji2013 opened this issue May 17, 2021 · 14 comments
Assignees

Comments

@zhouji2013
Copy link
Collaborator

Attached is the requirement v8 (December 2, 2020).
CTD2 Hierarchical search user level requirements draft - v8.docx

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

Need to add an hourglass-type busy indicator while ontology search is running. The search is slow, and as search results are already displayed on the page, and because the ontology search results will be very similar to the original search results, it is impossible to tell if the new results have arrived.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

The original search example for this issue was "non-hodgkin" which is expected not to return Burkitt's lymphoma when ontology search is not used, and to return Burkitt's lymphoma when ontology search is employed. However, Burkitt's is not returned in either case.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

If in test I search on "non-hodgkin lymphoma" in quotes, it returns all 40 results that mention "lymphoma", seemingly ignoring the requirements of the quotes to match the entire term. The production dashboard only returns one hit, for "follicular lymphoma", which has "non-hodgkin lymphoma" as a synonym.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

After an "ontology" search, the main search button still seems to be active (not greyed out), but it no longer launches a new regular search. It seems like it should.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

Here are some test cases (from Zhou):
• for disease context: search "organ", three results. "ontology search", 7 more results
• for ECO: test case: search ECO_0000059 and you will get one result. If you do "ontology search", you will get three more results, which are children of ECO_0000059.
• for observation: ECO_0000059 TP53. there is no direct 'intersection' but there will be intersection between child of ECO_0000059 (i.e. ECO_0000016) and TP53 so at least one observation result

I verified that each test case returned the results described, and that the results include new valid child nodes of the original search terms.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

It would be nice if we flagged the new results added by ontology search. We could put a tiny little blue triangle in the upper-right corner of the Name field of the results page for ontology driven matches.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 3, 2021

Implements #459.

@zhouji2013
Copy link
Collaborator Author

After an "ontology" search, the main search button still seems to be active (not greyed out), but it no longer launches a new regular search. It seems like it should.

I cannot reproduce this problem. Whether there is additional result or not, the button is disabled and greyed out. Did I misunderstand the description, or is the disabled color is not obvious enough? After the button is disabled, clicking the "Search" button (the original Search) will not re-activate it; you have to reload the page or navigate way to enable it again.

@kcs3
Copy link
Collaborator

kcs3 commented Aug 5, 2021

After an "ontology" search, the main search button still seems to be active (not greyed out), but it no longer launches a new regular search. It seems like it should.

I cannot reproduce this problem. Whether there is additional result or not, the button is disabled and greyed out. Did I misunderstand the description, or is the disabled color is not obvious enough? After the button is disabled, clicking the "Search" button (the original Search) will not re-activate it; you have to reload the page or navigate way to enable it again.

I am speaking of the button labeled "search". I do not see any visible difference in this button after an ontology search. Also, is there some reason why it needs to be disabled at all?

@zhouji2013
Copy link
Collaborator Author

After an "ontology" search, the main search button still seems to be active (not greyed out), but it no longer launches a new regular search. It seems like it should.

I cannot reproduce this problem. Whether there is additional result or not, the button is disabled and greyed out. Did I misunderstand the description, or is the disabled color is not obvious enough? After the button is disabled, clicking the "Search" button (the original Search) will not re-activate it; you have to reload the page or navigate way to enable it again.

I am speaking of the button labeled "search". I do not see any visible difference in this button after an ontology search. Also, is there some reason why it needs to be disabled at all?

I got it now. I misunderstood the original comment.

@zhouji2013
Copy link
Collaborator Author

Just to clarify the behavior of the main Search button. The button was never disabled. The confusion was caused by the design decision that ontology search is an interactive feature within the search page (with a stable URL) instead of being a different page. So the main Search button does not do anything because that is what it is supposed to do when the URL does not change. It is modified now to reload the page to eliminate the confusion. If a new search term is entered, Search button works as before and is not changed.

@zhouji2013
Copy link
Collaborator Author

Searching for "non-hodgkin" does not find Burkitt's lymphoma because currently ontology search only starts with the exact 'unobserved' parent terms. For example, "mature B-cell non-Hodgkin's lymphoma" is a parent term of "Burkitt's lymphoma". Basic search for "mature B-cell non-Hodgkin's lymphoma" (with quotes) does not return any result, but ontology search will return three results including "Burkitt's lymphoma".

@kcs3
Copy link
Collaborator

kcs3 commented Aug 16, 2021

Tested on cloud instance.

  1. a "busy" indicator was added,
  2. a small blue triangle was added in the subject column to mark ontology search results,
  3. a new search can be started from the search box after an ontology search.
  4. searching on "non-hodgkin lymphoma" in quotes returns only a single result, as expected
  5. no further action needed at this time on the "non-hodgkin's" ontology search.

@kcs3
Copy link
Collaborator

kcs3 commented Sep 15, 2021

Tested in production. Everything pretty much worked as expected. Searching for "mature B-cell non-Hodgkin's lymphoma" in quotes in basic search does not seem finish, it just keeps searching.... Will enter as separate issue. Suggest adding "busy" indicator to basic search just like we did for ontology search, will also add as new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants