-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ontology-Enhanced Search #487
Comments
Need to add an hourglass-type busy indicator while ontology search is running. The search is slow, and as search results are already displayed on the page, and because the ontology search results will be very similar to the original search results, it is impossible to tell if the new results have arrived. |
The original search example for this issue was "non-hodgkin" which is expected not to return Burkitt's lymphoma when ontology search is not used, and to return Burkitt's lymphoma when ontology search is employed. However, Burkitt's is not returned in either case. |
If in test I search on "non-hodgkin lymphoma" in quotes, it returns all 40 results that mention "lymphoma", seemingly ignoring the requirements of the quotes to match the entire term. The production dashboard only returns one hit, for "follicular lymphoma", which has "non-hodgkin lymphoma" as a synonym. |
After an "ontology" search, the main search button still seems to be active (not greyed out), but it no longer launches a new regular search. It seems like it should. |
Here are some test cases (from Zhou): I verified that each test case returned the results described, and that the results include new valid child nodes of the original search terms. |
It would be nice if we flagged the new results added by ontology search. We could put a tiny little blue triangle in the upper-right corner of the Name field of the results page for ontology driven matches. |
Implements #459. |
I cannot reproduce this problem. Whether there is additional result or not, the button is disabled and greyed out. Did I misunderstand the description, or is the disabled color is not obvious enough? After the button is disabled, clicking the "Search" button (the original Search) will not re-activate it; you have to reload the page or navigate way to enable it again. |
I am speaking of the button labeled "search". I do not see any visible difference in this button after an ontology search. Also, is there some reason why it needs to be disabled at all? |
I got it now. I misunderstood the original comment. |
Just to clarify the behavior of the main Search button. The button was never disabled. The confusion was caused by the design decision that ontology search is an interactive feature within the search page (with a stable URL) instead of being a different page. So the main Search button does not do anything because that is what it is supposed to do when the URL does not change. It is modified now to reload the page to eliminate the confusion. If a new search term is entered, Search button works as before and is not changed. |
Searching for "non-hodgkin" does not find Burkitt's lymphoma because currently ontology search only starts with the exact 'unobserved' parent terms. For example, "mature B-cell non-Hodgkin's lymphoma" is a parent term of "Burkitt's lymphoma". Basic search for "mature B-cell non-Hodgkin's lymphoma" (with quotes) does not return any result, but ontology search will return three results including "Burkitt's lymphoma". |
Tested on cloud instance.
|
Tested in production. Everything pretty much worked as expected. Searching for "mature B-cell non-Hodgkin's lymphoma" in quotes in basic search does not seem finish, it just keeps searching.... Will enter as separate issue. Suggest adding "busy" indicator to basic search just like we did for ontology search, will also add as new issue. |
Attached is the requirement v8 (December 2, 2020).
CTD2 Hierarchical search user level requirements draft - v8.docx
The text was updated successfully, but these errors were encountered: