Skip to content

Commit

Permalink
A0-3454: All e2e tests should be run also on release branches (#1467)
Browse files Browse the repository at this point in the history
# Description

In change
ad530be
all e2e tests except finalization have been moved to nightly. But we
need to automatically run them on the release branch as there are no
nightly release branches. There are seldom commits on release branches
so there should not be a problem for costs/developer synchronization.

Also, check runtime determinism is important to run, especially on the
release branches. Since is more important to run it on every release
candidate, not just nightly, I moved it to be run for every push to
`main` or release branch. Hence, we do not need nightly check runtime
determinism anymore.

Long integration tests like `clique network that are on nightly should
be run on release branch as well.

## Type of change

Please delete options that are not relevant.

- New feature (non-breaking change which adds functionality)
  • Loading branch information
Marcin-Radecki authored Oct 31, 2023
1 parent 79e9f52 commit 4f085b2
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 41 deletions.
41 changes: 0 additions & 41 deletions .github/workflows/nightly-check-runtime-determinism.yml

This file was deleted.

3 changes: 3 additions & 0 deletions .github/workflows/nightly-e2e-logic-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
workflow_dispatch:
schedule:
- cron: '00 21 * * *'
push:
branches:
- 'release-*'

concurrency:
group: ${{ github.ref }}-${{ github.workflow }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/nightly-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
workflow_dispatch:
schedule:
- cron: '00 01 * * *'
push:
branches:
- 'release-*'

concurrency:
group: "${{ github.ref }}-${{ github.workflow }}"
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/on-main-or-release-branch-commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ jobs:
name: Build production node and runtime
uses: ./.github/workflows/_build-production-node-and-runtime.yml

check-runtime-determinism:
needs: [build-production-node-and-runtime]
uses: ./.github/workflows/_check-runtime-determimism.yml

store-production-node-and-runtime-in-mainnet-s3:
name: Store production node and runtime in Mainnet bucket
runs-on: ubuntu-20.04
Expand Down

0 comments on commit 4f085b2

Please sign in to comment.