A0-3310: Tidy up double quotes #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
requested review from
Kosiare
approved these changes
Nov 2, 2023
Marcin-Radecki
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
While I agree with enclosing all github expressions in single quotes, I think it'll be better if we stay with double quotes in bash snippets. This is because, in general in bash it is better to use double quotes, from our bash style guide:
This prevents reinterpretation of all special characters within the quoted string — except $, ` (backquote), and \ (escape).
Keeping $ as a special character within double quotes permits referencing a quoted variable ("$variable"), that is, replacing the variable with its value.
so now if we stay in single quotes in bash snippets, and someone will add bash some variable ${var}, it will be directly interpreted as ${var} string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary double quotes in the workflow files. Also, tidies up some variable names and make use of
${{ env.VAR }}everywhere, for the consistency and security.Type of change
Please review carefully. We cannot break deployment workflows.
Checklist: