NPCs can funk out to music, too.

[RenechCDDA]

Summary

Balance "NPCs can funk out to music, too."

Purpose of change

...Also NPCs couldn't enjoy music played from vehicle/appliance stereos.

Describe the solution

Properly check for everyone that can hear the music, and make them feel the groove.

Pipe musical_instrument_actor::use through iuse::play_music to minimize code duplication

Describe alternatives you've considered

Ehhh maybe there's a way to do this without lambdas. I know a lot of people don't like lambdas, but I've gotten used to them and these are pretty simple.

vehicle::play_music() probably shouldn't assume the player character and pass it on as Character *p?

Testing

instrument played by the player

2024-10-18.16-32-28.mp4

vehicle/appliance stereo

2024-10-18.16-45-04.mp4

Apparently there may be some way for NPCs to play instruments and for you to listen, but I wasn't able to find out how. Still I structured my changes so that anything that previously worked should continue to work.

Additional context

[PatrikLundell]

Comment about lambdas:
The part I dislike about lambdas (apart from their weird and non intuitive syntax) is how they break easily resulting in non intuitive error reports in odd places seemingly unrelated to changes made. This behavior can be reduced by not using the failure prone "auto" return typing, but actually stating the type of the return value, as this will flag where the type clashes are rather than the mess this causes otherwise.