-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prp to handle mykrobe csv format #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Mykrobe parser seems to be parsing resistance variants as resistance genes.
For instance is katG_S315T
from the test output file is being parsed as a gene and not a variant.
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR is also intended to be prepared for release we should also add
## [Unreleased]
### Added
### Fixed
### Changed
|
Yes, Mykrobe report variants with the following format
https://github.com/Mykrobe-tools/mykrobe/wiki/AMR-prediction-output |
No I understand that, just wondering if you mean that I must only report a variant in mykrobe's case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its getting closer.
The parser cant handle when there are multiple variants yielding the same resistance. For instance Rifampicin resistance in the test file,
mykrobe report that it is caused by three deletions,
rpoB_TCATGGA1298T-TCATGGA761104T:152:2108:14397
rpoB_TTCATGGA1297TT-TTCATGGA761103TT:303:1978:13279
rpoB_CTGAGCCAATTCATGGACCAGAACAACCC1288CTGAGCCAATTCCAGAACAACCC-CTGAGCCAATTCATGGACCAGAACAACCC761094CTGAGCCAATTCCAGAACAACCC:1:2505:16677
The current iteration of the parser only reports one variant
{'alt_aa': None,
'alt_nt': 'T',
'annotation': None,
'ass_end_pos': None,
'ass_start_pos': None,
'change': 'TCATGGA1298T',
'close_seq_name': None,
'contig_id': None,
'depth': 16677.0,
'drugs': ['rifampicin'],
'element_subtype': None,
'element_type': 'AMR',
'gene_symbol': 'rpoB',
'method': 'kmer_count',
'nucleotide_change': 'c.TCATGGA761104T',
'phenotypes': [],
'position': 761104,
'protein_change': 'p.TCATGGA1298T',
'ref_aa': None,
'ref_database': None,
'ref_id': None,
'ref_nt': 'TCATGGA',
'res_class': None,
'res_subclass': None,
'sequence_name': None,
'strand': None,
'target_length': None,
'type': None,
'variant_type': 'deletion'}
Solved! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Well done!
No description provided.