Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use literals to ensure that data is being cast into right datamodel #72

Merged

Conversation

mhkc
Copy link
Collaborator

@mhkc mhkc commented Jun 3, 2024

This PR fixes an issue where the pydantic picked the wrong data models when casting PRP output data into the PipelineResult data structure. This would cause issues for Bonsai.

@mhkc mhkc linked an issue Jun 3, 2024 that may be closed by this pull request
@mhkc mhkc requested a review from svartapaerlan June 4, 2024 08:49
Copy link
Contributor

@svartapaerlan svartapaerlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhkc mhkc merged commit 74e2f7b into master Jun 4, 2024
7 checks passed
@mhkc mhkc deleted the 71-different-datamodels-are-used-when-data-is-being-read-again branch June 4, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different datamodels are used when data is being read again
2 participants