Stockholm transfer #168
Closed
Stockholm transfer #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switched to cherry picking to give credits where they are due |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a functionality or fixes a bug.
OR
This PR marks a new Gens release. We apply semantic versioning. This is a major/minor/patch release for reasons.
How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review:
Discussion points
.githubworkflows set up by Stockholm? (Working with their instance)case_id. What consequences? I suspect we will need to migrate our Gens db before merge.generate_gens_data.plandgvcfvaf.pl. Needs to be tested separately? We are using a different script in the ol' wgs repo?