Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert earlier changes #3689

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Revert earlier changes #3689

merged 4 commits into from
Sep 4, 2024

Conversation

beatrizsavinhas
Copy link
Contributor

Description

Related to #2871

Reverting changes from https://github.com/Clinical-Genomics/cg/pull/3681/files, https://github.com/Clinical-Genomics/cg/pull/3682/files and https://github.com/Clinical-Genomics/cg/pull/3684/files.

Fixed

  • Reverted changes from earlier PRs.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta): 
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@beatrizsavinhas beatrizsavinhas requested a review from a team as a code owner September 4, 2024 13:18
@beatrizsavinhas beatrizsavinhas marked this pull request as draft September 4, 2024 13:19
islean
islean approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@islean islean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@beatrizsavinhas beatrizsavinhas marked this pull request as ready for review September 4, 2024 13:28
@beatrizsavinhas beatrizsavinhas changed the title Revert earlier changes. Revert earlier changes Sep 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@karlnyr karlnyr mentioned this pull request Sep 4, 2024
Closed
@beatrizsavinhas beatrizsavinhas merged commit 786c61d into master Sep 4, 2024
9 checks passed
@beatrizsavinhas beatrizsavinhas deleted the 2871-revert-changes branch September 4, 2024 13:32
Karl-Svard added a commit that referenced this pull request Sep 25, 2024
@Karl-Svard
Revert "Revert earlier changes (#3689)"
bbc3b4b 
This reverts commit 786c61d.
@Karl-Svard Karl-Svard mentioned this pull request Sep 25, 2024
Merged
Karl-Svard added a commit that referenced this pull request Sep 26, 2024
@Karl-Svard
Revert "Revert earlier changes (#3689)" (#3769)(patch)
abcb885 
### Changed
- Reverts the commit in PR #3689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islean islean islean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beatrizsavinhas @islean