-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sequencing artifact manager #407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi looks nice. Made some comments about potential structure changes that could make it more robust with the use of BaseModels instead of nested dicts. Would likely require some work. But up to you.
I think @Karl-Svard has to approve changes here as the code owner, so commetning for now.
Nicely done! Just had some minor tweaks:
Please take look and just ask if you wonder anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! 💯
This PR adds a class and utility functions for managing (retrieving and updating) artifacts from lims related to sequencing. This class will be used in the new script for the sample sequencing quality control. Part of project https://github.com/Clinical-Genomics/project-planning/issues/482.
So this class will be a component of the new script replacing https://github.com/Clinical-Genomics/clinical_EPPs/blob/master/EPPs/bcl2fastq.py.
I don't like how the new functions spread out across so many files, please let me know if there are other spots where they belong better or already exist. I don't think there was a super obvious structure to follow, so I bet that can be improved.
Added
This version is a: