Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count NTC reads in sequencing QC check #531

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Count NTC reads in sequencing QC check #531

merged 3 commits into from
Sep 25, 2024

Conversation

Karl-Svard
Copy link
Collaborator

@Karl-Svard Karl-Svard commented Sep 24, 2024

Changed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard
Copy link
Collaborator Author

Tests on stage

Before change

Screenshot 2024-09-24 at 15 37 35

After change

Screenshot 2024-09-24 at 15 36 16

@Karl-Svard
Copy link
Collaborator Author

Branch works as intended. Ready for review! @idalindegaard

@Karl-Svard Karl-Svard changed the title Counts NTC reads in sequencing QC check Count NTC reads in sequencing QC check Sep 24, 2024
Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update and good job! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants