-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(contract)(sdk): Stop supporting unused arrays in Registries #799
Merged
alainncls
merged 4 commits into
dev
from
chore/stop-supporting-unused-arrays-in-registries
Nov 19, 2024
Merged
chore(contract)(sdk): Stop supporting unused arrays in Registries #799
alainncls
merged 4 commits into
dev
from
chore/stop-supporting-unused-arrays-in-registries
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyajeetkolhapure
requested review from
alainncls,
orbmis and
arthur-remy
as code owners
November 11, 2024 22:12
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #799 +/- ##
===========================================
+ Coverage 46.80% 74.88% +28.08%
===========================================
Files 18 49 +31
Lines 391 888 +497
Branches 59 182 +123
===========================================
+ Hits 183 665 +482
- Misses 205 220 +15
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
alainncls
requested changes
Nov 14, 2024
satyajeetkolhapure
force-pushed
the
chore/stop-supporting-unused-arrays-in-registries
branch
from
November 15, 2024 11:33
f6cee0b
to
b497da5
Compare
alainncls
approved these changes
Nov 19, 2024
alainncls
deleted the
chore/stop-supporting-unused-arrays-in-registries
branch
November 19, 2024 08:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed the usage of onchain counter from entities.
Updated sdk to use subgraph instead.
Related ticket
Fixes #788
Type of change
Check list