Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contract)(sdk): Stop supporting unused arrays in Registries #799

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Nov 11, 2024

What does this PR do?

Removed the usage of onchain counter from entities.
Updated sdk to use subgraph instead.

Related ticket

Fixes #788

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.88%. Comparing base (af2042b) to head (b497da5).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
sdk/src/dataMapper/ModuleDataMapper.ts 0.00% 8 Missing ⚠️
sdk/src/dataMapper/PortalDataMapper.ts 0.00% 1 Missing ⚠️
sdk/src/dataMapper/SchemaDataMapper.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #799       +/-   ##
===========================================
+ Coverage   46.80%   74.88%   +28.08%     
===========================================
  Files          18       49       +31     
  Lines         391      888      +497     
  Branches       59      182      +123     
===========================================
+ Hits          183      665      +482     
- Misses        205      220       +15     
  Partials        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

contracts/src/ModuleRegistry.sol Outdated Show resolved Hide resolved
contracts/src/PortalRegistry.sol Outdated Show resolved Hide resolved
contracts/src/SchemaRegistry.sol Outdated Show resolved Hide resolved
sdk/src/dataMapper/ModuleDataMapper.ts Outdated Show resolved Hide resolved
sdk/src/dataMapper/SchemaDataMapper.ts Outdated Show resolved Hide resolved
sdk/src/dataMapper/UtilsDataMapper.ts Outdated Show resolved Hide resolved
sdk/src/dataMapper/ModuleDataMapper.ts Show resolved Hide resolved
sdk/src/dataMapper/SchemaDataMapper.ts Show resolved Hide resolved
@satyajeetkolhapure satyajeetkolhapure force-pushed the chore/stop-supporting-unused-arrays-in-registries branch from f6cee0b to b497da5 Compare November 15, 2024 11:33
@alainncls alainncls merged commit 6725ef2 into dev Nov 19, 2024
9 checks passed
@alainncls alainncls deleted the chore/stop-supporting-unused-arrays-in-registries branch November 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Stop supporting unused arrays in Registries
3 participants