Add pull request template #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeipollack
reviewed
Dec 19, 2023
.github/pull_request_template.md
Outdated
| ## Summary | ||
|
|
||
| > Developers should provide a summary of the proposed changes here and include "closes #<ISSUE NUMBER>" if this addresses an open issue. | ||
| > Developers should include validation test reports demonstrating that the reported errors have been solved. |
There was a problem hiding this comment.
Delete L4 bc it will be moved.
Add a space after L3.
And then add the text below:
Validation Test Reports
Developers should include training and metrics validation test reports demonstrating that all tests passed.
(Copy and paste the output of validation tests report here in markdown.)
|
Hi @nadamoukaddem , I just have a few small change requests for the template. Thanks! |
|
Forgot to comment your own Pull Request does not follow the template checklist. You didn't assign the appropriate labels. See screenshot. |
|
@nadamoukaddem you still didn't apply the changes I requested above to the template. Until then this PR can't be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #105
Added the pull_request_template.md file
To verify its automatic loading, I forked the project, and everything worked as expected.