-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pull request template #107
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
## Summary | ||
|
||
> Developers should provide a summary of the proposed changes here and include "closes #<ISSUE NUMBER>" if this addresses an open issue. | ||
> Developers should include validation test reports demonstrating that the reported errors have been solved. | ||
|
||
## Reviewer Checklist | ||
|
||
> Reviewers should tick the following boxes before approving and merging the PR. | ||
|
||
- [ ] The PR targets the `develop` branch | ||
- [ ] The PR is assigned to the developer | ||
- [ ] The PR has appropriate labels | ||
- [ ] The PR is included in appropriate projects and/or milestones | ||
- [ ] The PR includes a clear description of the proposed changes | ||
- [ ] If the PR addresses an open issue the description includes "closes #<ISSUE NUMBER>" | ||
- [ ] The code and documentation style match the current standards | ||
- [ ] Documentation has been added/updated consistently with the code | ||
- [ ] All CI tests are passing | ||
- [ ] API docs have been built and checked at least once (if relevant) | ||
- [ ] All changed files have been checked and comments provided to the developer | ||
- [ ] All of the reviewer's comments have been satisfactorily addressed by the developer | ||
- [ ] All Validation tests for the reported error are passing | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete L4 bc it will be moved.
Add a space after L3.
And then add the text below:
Validation Test Reports
(Copy and paste the output of validation tests report here in markdown.)