Feature unit tests run configs - MetricsConfigHandler Class #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeipollack
changed the title
sfarrens
reviewed
Nov 15, 2023
|
@jeipollack once you resolve the thread above this PR can be merged |
Merged
sfarrens
approved these changes
Nov 16, 2023
|
I added pytest.xml yesterday to .gitignore but forgot to comment so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a few unit tests for the
configs_handler.pymodule and one for thepsf_models.pymodule.This lead to some code refactoring of the
MetricsConfigHandlerclass, which introduced some bugs during the process in some commits (corrected).Unit tests passed and validation tests which check reproducibility under a couple of different configurations passed.
I would like this PR to go to
dummy_main. I spotted missed unused code which I forgot to delete.